From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2 2/2] Input: amikbd - Allocate temporary keymap buffer on the stack Date: Wed, 3 Dec 2014 14:59:34 -0800 Message-ID: <20141203225934.GF16951@dtor-ws> References: <1417339820-5285-1-git-send-email-geert@linux-m68k.org> <1417339820-5285-2-git-send-email-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-ie0-f178.google.com ([209.85.223.178]:54634 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088AbaLCW7j (ORCPT ); Wed, 3 Dec 2014 17:59:39 -0500 Content-Disposition: inline In-Reply-To: <1417339820-5285-2-git-send-email-geert@linux-m68k.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Geert Uytterhoeven Cc: linux-input@vger.kernel.org, linux-m68k@vger.kernel.org On Sun, Nov 30, 2014 at 10:30:20AM +0100, Geert Uytterhoeven wrote: > Allocate the temporary buffer needed for initialization of the console > keyboard maps (512 bytes, as NR_KEYS = 256) on the stack instead of > statically, to reduce kernel size. > > add/remove: 0/1 grow/shrink: 0/0 up/down: 0/-512 (-512) > function old new delta > temp_map 512 - -512 So because it is marked __initdata and is placed into a separate section we have to allocate the space in the image? Anyway, applied both, thank you. > > Signed-off-by: Geert Uytterhoeven > --- > v2: > - Allocate temp_map[] on the stack instead of using kmalloc(). > --- > drivers/input/keyboard/amikbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/amikbd.c b/drivers/input/keyboard/amikbd.c > index 4f81e65d9e35cb7d..60580d8104b9f970 100644 > --- a/drivers/input/keyboard/amikbd.c > +++ b/drivers/input/keyboard/amikbd.c > @@ -147,10 +147,10 @@ static unsigned char amikbd_keycode[0x78] __initdata = { > > static void __init amikbd_init_console_keymaps(void) > { > + unsigned short temp_map[NR_KEYS]; > int i, j; > > for (i = 0; i < MAX_NR_KEYMAPS; i++) { > - static u_short temp_map[NR_KEYS] __initdata; > if (!key_maps[i]) > continue; > memset(temp_map, 0, sizeof(temp_map)); > -- > 1.9.1 > -- Dmitry