From: Asaf Vertz <asaf.vertz@tandemg.com>
To: dmitry.torokhov@gmail.com
Cc: LW@KARO-electronics.de, B38611@freescale.com, maksqwe1@ukr.net,
jg1.han@samsung.com, linux@rasmusvillemoes.dk, fabf@skynet.be,
joe@perches.com, asaf.vertz@tandemg.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] input: edt-ft5x06: fixed a macro coding style issue
Date: Tue, 9 Dec 2014 10:08:16 +0200 [thread overview]
Message-ID: <20141209080816.GA19581@ubuntu> (raw)
Fixed a coding style error, macros with complex values should be
enclosed in parentheses.
Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>
---
Changes in v2:
- use do {...} while (0) instead of {...}
drivers/input/touchscreen/edt-ft5x06.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index ee3434f..d22ed56 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -850,9 +850,11 @@ static int edt_ft5x06_ts_identify(struct i2c_client *client,
}
#define EDT_ATTR_CHECKSET(name, reg) \
+do { \
if (pdata->name >= edt_ft5x06_attr_##name.limit_low && \
pdata->name <= edt_ft5x06_attr_##name.limit_high) \
- edt_ft5x06_register_write(tsdata, reg, pdata->name)
+ edt_ft5x06_register_write(tsdata, reg, pdata->name); \
+} while (0)
#define EDT_GET_PROP(name, reg) { \
u32 val; \
--
1.7.0.4
next reply other threads:[~2014-12-09 8:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 8:08 Asaf Vertz [this message]
2014-12-13 18:59 ` [PATCH v2] input: edt-ft5x06: fixed a macro coding style issue Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209080816.GA19581@ubuntu \
--to=asaf.vertz@tandemg.com \
--cc=B38611@freescale.com \
--cc=LW@KARO-electronics.de \
--cc=dmitry.torokhov@gmail.com \
--cc=fabf@skynet.be \
--cc=jg1.han@samsung.com \
--cc=joe@perches.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=maksqwe1@ukr.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).