From: Jeremiah Mahler <jmmahler@gmail.com>
To: Dudley Du <dudley.dulixin@gmail.com>
Cc: dmitry.torokhov@gmail.com, rydberg@euromail.se,
bleung@google.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 09/12] input: cyapa: add gen5 trackpad device firmware update function support
Date: Tue, 9 Dec 2014 19:33:03 -0800 [thread overview]
Message-ID: <20141210033303.GA4173@hudson.localdomain> (raw)
In-Reply-To: <1418116304-11392-10-git-send-email-dudley.dulixin@gmail.com>
Dudley,
On Tue, Dec 09, 2014 at 05:11:41PM +0800, Dudley Du wrote:
> Add firmware image update function supported for gen5 trackpad device,
> it can be used through sysfs update_fw interface.
> TEST=test on Chromebooks.
>
> Signed-off-by: Dudley Du <dudley.dulixin@gmail.com>
> ---
> drivers/input/mouse/Kconfig | 2 +-
> drivers/input/mouse/cyapa_gen5.c | 290 +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 291 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig
> index d8b46b0..63e8b40 100644
> --- a/drivers/input/mouse/Kconfig
> +++ b/drivers/input/mouse/Kconfig
> @@ -205,7 +205,7 @@ config MOUSE_BCM5974
>
> config MOUSE_CYAPA
> tristate "Cypress APA I2C Trackpad support"
> - depends on I2C
> + depends on I2C && CRC_ITU_T
> help
> This driver adds support for Cypress All Points Addressable (APA)
> I2C Trackpads, including the ones used in 2012 Samsung Chromebooks.
> diff --git a/drivers/input/mouse/cyapa_gen5.c b/drivers/input/mouse/cyapa_gen5.c
My initial config had MOUSE_CYAPA=m and CRC_ITU_T=n.
I did a 'make oldconfig', no questions were asked, but it removed
MOUSE_CYAPA since CRC_ITU_T wasn't enabled. Since the cyapa modules
were removed the touchpad no longer works. Not a very good upgrade path :-(
To fix this I have to manually enable MOUSE_CYAPA and CRC_ITU_T to get
it working again.
[...]
--
- Jeremiah Mahler
next prev parent reply other threads:[~2014-12-10 3:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 9:11 [PATCH v13 00/12] input: cyapa: instruction of cyapa patches Dudley Du
2014-12-09 9:11 ` [PATCH v13 01/12] input: cyapa: re-design driver to support multi-trackpad in one driver Dudley Du
2014-12-09 9:11 ` [PATCH v13 02/12] input: cyapa: add gen5 trackpad device basic functions support Dudley Du
2014-12-09 9:11 ` [PATCH v13 03/12] input: cyapa: add power management interfaces supported for the device Dudley Du
2014-12-09 9:11 ` [PATCH v13 04/12] input: cyapa: add runtime " Dudley Du
2014-12-09 9:11 ` [PATCH v13 05/12] input: cyapa: add sysfs interfaces supported in the cyapa driver Dudley Du
2014-12-09 9:11 ` [PATCH v13 06/12] input: cyapa: add gen3 trackpad device firmware update function support Dudley Du
2014-12-09 9:11 ` [PATCH v13 07/12] input: cyapa: add gen3 trackpad device read baseline " Dudley Du
2014-12-09 9:11 ` [PATCH v13 08/12] input: cyapa: add gen3 trackpad device force re-calibrate " Dudley Du
2014-12-09 9:11 ` [PATCH v13 09/12] input: cyapa: add gen5 trackpad device firmware update " Dudley Du
2014-12-10 3:33 ` Jeremiah Mahler [this message]
2014-12-10 8:54 ` Jeremiah Mahler
2014-12-10 9:19 ` Dudley Du
2014-12-10 11:06 ` Jeremiah Mahler
2014-12-09 9:11 ` [PATCH v13 10/12] input: cyapa: add gen5 trackpad device read baseline " Dudley Du
2014-12-10 4:02 ` Jeremiah Mahler
2014-12-09 9:11 ` [PATCH v13 11/12] input: cyapa: add gen5 trackpad device force re-calibrate " Dudley Du
2014-12-10 4:05 ` Jeremiah Mahler
2014-12-09 9:11 ` [PATCH v13 12/12] input: cyapa: add acpi device id supported Dudley Du
2014-12-10 4:10 ` [PATCH v13 00/12] input: cyapa: instruction of cyapa patches Jeremiah Mahler
2014-12-10 5:10 ` Dudley Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210033303.GA4173@hudson.localdomain \
--to=jmmahler@gmail.com \
--cc=bleung@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dudley.dulixin@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).