* Re: [PATCHv2 3/3] ARM:dts:sunxi:ps2 dt nodes for A10/A20 PS2 controller. [not found] ` <CAEzqOZu49Z99B4DWvuD=E2BKs7ihSVAunshheUn=Z-VAqivUxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2014-12-11 21:15 ` Maxime Ripard 0 siblings, 0 replies; 3+ messages in thread From: Maxime Ripard @ 2014-12-11 21:15 UTC (permalink / raw) To: Vishnu Patekar Cc: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w, linux-lFZ/pmaqli7XmaaqVzeoHQ, leafy.myeh-Q9AEpCAkrSgqDJ6do+/SaQ, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-input-u79uwXL29TY76Z2rM5mHXA, vishnupatekar [-- Attachment #1: Type: text/plain, Size: 1420 bytes --] Hi, Please keep the Cc list. On Wed, Dec 10, 2014 at 01:39:52AM +0530, Vishnu Patekar wrote: > > > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > > > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > > > @@ -112,6 +112,19 @@ > > > pinctrl-0 = <&uart0_pins_a>; > > > status = "okay"; > > > }; > > > + /* PS2 0 and PS2 1 are disabled by default > > > + To enable PS2 0 and PS2 1 uncomment below ps20 and ps21 > > nodes > > > + Please note that ps20 pins conflict with HDMI on Lime2 > > Board*/ > > > + /*ps20: ps2@0x01c2a000 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&ps2_0_pins>; > > > + status = "okay"; > > > + }; > > > + ps21: ps2@0x01c2a400 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&ps2_1_pins>; > > > + status = "okay"; > > > + };*/ > > > > Hmmm, no, no comments in the DTS. > > > > Especially when it's that trivial to enable. > > Okie, I'll just keep ps20 and ps21 nodes commented. No, the comments themselves were great. But the nodes themselves shouldn't be there in the first place. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCHv2 0/3] ARM:sunxi:ps2 Added support for A10/A20 ps2 controller.
@ 2014-12-06 23:15 vishnupatekar
[not found] ` <1417907719-26775-1-git-send-email-VishnuPatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: vishnupatekar @ 2014-12-06 23:15 UTC (permalink / raw)
To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw,
dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: leafy.myeh-Q9AEpCAkrSgqDJ6do+/SaQ, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-input-u79uwXL29TY76Z2rM5mHXA, vishnupatekar
Here is v2 of SUNXI PS2 controller support patch-set as with v1.
Changes in v2:
1. added default n depends on ARCH_SUNXI || COMPILE_TEST in Kconfig.
2. handled errors and free resources on errors.
3. used BIT(x), DIV_ROUND_UP macros.
4. corrected style errors.
5. added support for A10 also, A10 and A2 have same properties of PS2 controller.
6. by default commented ps20 and ps21 nodes,as ps20 pins conflict with HDMI
connector on Lime2 Board.
7. added compatible as allwinner,sun4i-a10-ps2.
8. corrected the possible race condition.
Patch 0 Summary: Allwinner A10/A20 PS2 controller. These modifications are
for PS2 host controller. IBM compliant IBM PS2 and AT-compatible
keyboard and mouse can be connected.
Patch 1 device tree bindings.
Patch 2 adds support for sun7i ps2 driver.
Patch 3 device tree support for PS2 controller.
1) Added A10/A20 ps2 nodes to the dtsi
2) Added A10/A20 ps2 pinmux to the dtsi
3) Added ps2 nodes to the lime2 dts file
vishnupatekar (3):
sunxi:dts-bindings:input:ps2 bindings for A10/A20 ps2.
sunxi:drivers:input:ps2 Added sunxi A10/A20 ps2 driver
ARM:dts:sunxi:ps2 dt nodes for A10/A20 PS2 controller.
.../bindings/input/allwinner,sunxi-ps2.txt | 23 ++
arch/arm/boot/dts/sun4i-a10.dtsi | 27 ++
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 13 +
arch/arm/boot/dts/sun7i-a20.dtsi | 29 ++
drivers/input/serio/Kconfig | 10 +
drivers/input/serio/Makefile | 1 +
drivers/input/serio/sunxi-ps2.c | 364 ++++++++++++++++++++
7 files changed, 467 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/allwinner,sunxi-ps2.txt
create mode 100644 drivers/input/serio/sunxi-ps2.c
--
1.7.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <1417907719-26775-1-git-send-email-VishnuPatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* [PATCHv2 3/3] ARM:dts:sunxi:ps2 dt nodes for A10/A20 PS2 controller. [not found] ` <1417907719-26775-1-git-send-email-VishnuPatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-12-06 23:15 ` vishnupatekar [not found] ` <1417907719-26775-4-git-send-email-VishnuPatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: vishnupatekar @ 2014-12-06 23:15 UTC (permalink / raw) To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8, linux-lFZ/pmaqli7XmaaqVzeoHQ Cc: leafy.myeh-Q9AEpCAkrSgqDJ6do+/SaQ, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-input-u79uwXL29TY76Z2rM5mHXA, vishnupatekar Added ps2 nodes in lime2 board dts. By default ps20 and ps21 nodes are commented as ps20 pins conflict with HDMI connector on Lime2 Board. Signed-off-by: vishnupatekar <VishnuPatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- arch/arm/boot/dts/sun4i-a10.dtsi | 27 +++++++++++++++++++++ arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 13 ++++++++++ arch/arm/boot/dts/sun7i-a20.dtsi | 29 +++++++++++++++++++++++ 3 files changed, 69 insertions(+) diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi index 5e2ec2d..4726e8d 100644 --- a/arch/arm/boot/dts/sun4i-a10.dtsi +++ b/arch/arm/boot/dts/sun4i-a10.dtsi @@ -615,6 +615,19 @@ allwinner,drive = <0>; allwinner,pull = <0>; }; + ps2_0_pins: ps2_0@0 { + allwinner,pins = "PI20","PI21"; + allwinner,function = "ps2"; + allwinner,drive = <0>; + allwinner,pull = <0>; + }; + ps2_1_pins: ps2_1@0 { + allwinner,pins = "PH12","PH13"; + allwinner,function = "ps2"; + allwinner,drive = <0>; + allwinner,pull = <0>; + }; + }; timer@01c20c00 { @@ -781,5 +794,19 @@ #address-cells = <1>; #size-cells = <0>; }; + ps20: ps2@0x01c2a000 { + compatible = "allwinner,sun4i-a10-ps2"; + reg = <0x01c2a000 0x400>; + interrupts = <0 62 4>; + clocks = <&apb1_gates 6>; + status = "disabled"; + }; + ps21: ps2@0x01c2a400 { + compatible = "allwinner,sun4i-a10-ps2"; + reg = <0x01c2a400 0x400>; + interrupts = <0 63 4>; + clocks = <&apb1_gates 7>; + status = "disabled"; + }; }; }; diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts index ed364d5..5624e63 100644 --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts @@ -112,6 +112,19 @@ pinctrl-0 = <&uart0_pins_a>; status = "okay"; }; + /* PS2 0 and PS2 1 are disabled by default + To enable PS2 0 and PS2 1 uncomment below ps20 and ps21 nodes + Please note that ps20 pins conflict with HDMI on Lime2 Board*/ + /*ps20: ps2@0x01c2a000 { + pinctrl-names = "default"; + pinctrl-0 = <&ps2_0_pins>; + status = "okay"; + }; + ps21: ps2@0x01c2a400 { + pinctrl-names = "default"; + pinctrl-0 = <&ps2_1_pins>; + status = "okay"; + };*/ i2c0: i2c@01c2ac00 { pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index 8605f2b..96fe37d 100644 --- a/arch/arm/boot/dts/sun7i-a20.dtsi +++ b/arch/arm/boot/dts/sun7i-a20.dtsi @@ -852,6 +852,19 @@ allwinner,drive = <0>; allwinner,pull = <0>; }; + ps2_0_pins: ps2_0@0 { + allwinner,pins = "PI20","PI21"; + allwinner,function = "ps2"; + allwinner,drive = <0>; + allwinner,pull = <0>; + }; + ps2_1_pins: ps2_1@0 { + allwinner,pins = "PH12","PH13"; + allwinner,function = "ps2"; + allwinner,drive = <0>; + allwinner,pull = <0>; + }; + }; timer@01c20c00 { @@ -1079,5 +1092,21 @@ #interrupt-cells = <3>; interrupts = <1 9 0xf04>; }; + ps20: ps2@0x01c2a000 { + compatible = "allwinner,sun7i-a20-ps2"; + reg = <0x01c2a000 0x400>; + interrupts = <0 62 4>; + clocks = <&apb1_gates 6>; + status = "disabled"; + }; + ps21: ps2@0x01c2a400 { + compatible = "allwinner,sun7i-a20-ps2"; + reg = <0x01c2a400 0x400>; + interrupts = <0 63 4>; + clocks = <&apb1_gates 7>; + status = "disabled"; + }; + + }; }; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <1417907719-26775-4-git-send-email-VishnuPatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCHv2 3/3] ARM:dts:sunxi:ps2 dt nodes for A10/A20 PS2 controller. [not found] ` <1417907719-26775-4-git-send-email-VishnuPatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-12-08 22:22 ` Maxime Ripard 0 siblings, 0 replies; 3+ messages in thread From: Maxime Ripard @ 2014-12-08 22:22 UTC (permalink / raw) To: vishnupatekar Cc: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w, linux-lFZ/pmaqli7XmaaqVzeoHQ, leafy.myeh-Q9AEpCAkrSgqDJ6do+/SaQ, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-input-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 3421 bytes --] Hi, Your commit title should be less that 80 chars. It should also be formatted using "ARM: sunxi: dts:" as a prefix (More specific to less specific). On Sun, Dec 07, 2014 at 04:45:19AM +0530, vishnupatekar wrote: > Added ps2 nodes in lime2 board dts. By default ps20 and ps21 nodes are > commented as ps20 pins conflict with HDMI connector > on Lime2 Board. > > Signed-off-by: vishnupatekar <VishnuPatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > arch/arm/boot/dts/sun4i-a10.dtsi | 27 +++++++++++++++++++++ > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 13 ++++++++++ > arch/arm/boot/dts/sun7i-a20.dtsi | 29 +++++++++++++++++++++++ > 3 files changed, 69 insertions(+) This patch should also be split into three different patches: - The one adding the nodes for the controller to the DTSI - The one adding the pinctrl nodes - The one enabling the controller on the board. > > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi > index 5e2ec2d..4726e8d 100644 > --- a/arch/arm/boot/dts/sun4i-a10.dtsi > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi > @@ -615,6 +615,19 @@ > allwinner,drive = <0>; > allwinner,pull = <0>; > }; A newline here please. > + ps2_0_pins: ps2_0@0 { You called the node ps20, you probably want to call it the same way here. And we usually have a suffix like pins_a whenever we have several muxing options (as it's probably the case). > + allwinner,pins = "PI20","PI21"; A whitespace after the comma please. > + allwinner,function = "ps2"; > + allwinner,drive = <0>; > + allwinner,pull = <0>; > + }; Newline. > + ps2_1_pins: ps2_1@0 { > + allwinner,pins = "PH12","PH13"; > + allwinner,function = "ps2"; > + allwinner,drive = <0>; > + allwinner,pull = <0>; > + }; > + > }; > > timer@01c20c00 { > @@ -781,5 +794,19 @@ > #address-cells = <1>; > #size-cells = <0>; > }; Newline. > + ps20: ps2@0x01c2a000 { Drop the 0x > + compatible = "allwinner,sun4i-a10-ps2"; > + reg = <0x01c2a000 0x400>; > + interrupts = <0 62 4>; > + clocks = <&apb1_gates 6>; > + status = "disabled"; > + }; Newline > + ps21: ps2@0x01c2a400 { > + compatible = "allwinner,sun4i-a10-ps2"; > + reg = <0x01c2a400 0x400>; > + interrupts = <0 63 4>; > + clocks = <&apb1_gates 7>; > + status = "disabled"; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > index ed364d5..5624e63 100644 > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > @@ -112,6 +112,19 @@ > pinctrl-0 = <&uart0_pins_a>; > status = "okay"; > }; > + /* PS2 0 and PS2 1 are disabled by default > + To enable PS2 0 and PS2 1 uncomment below ps20 and ps21 nodes > + Please note that ps20 pins conflict with HDMI on Lime2 Board*/ > + /*ps20: ps2@0x01c2a000 { > + pinctrl-names = "default"; > + pinctrl-0 = <&ps2_0_pins>; > + status = "okay"; > + }; > + ps21: ps2@0x01c2a400 { > + pinctrl-names = "default"; > + pinctrl-0 = <&ps2_1_pins>; > + status = "okay"; > + };*/ Hmmm, no, no comments in the DTS. Especially when it's that trivial to enable. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-11 21:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAEzqOZu49Z99B4DWvuD=E2BKs7ihSVAunshheUn=Z-VAqivUxA@mail.gmail.com>
[not found] ` <CAEzqOZu49Z99B4DWvuD=E2BKs7ihSVAunshheUn=Z-VAqivUxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-11 21:15 ` [PATCHv2 3/3] ARM:dts:sunxi:ps2 dt nodes for A10/A20 PS2 controller Maxime Ripard
2014-12-06 23:15 [PATCHv2 0/3] ARM:sunxi:ps2 Added support for A10/A20 ps2 controller vishnupatekar
[not found] ` <1417907719-26775-1-git-send-email-VishnuPatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-06 23:15 ` [PATCHv2 3/3] ARM:dts:sunxi:ps2 dt nodes for A10/A20 PS2 controller vishnupatekar
[not found] ` <1417907719-26775-4-git-send-email-VishnuPatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-08 22:22 ` Maxime Ripard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).