From: Jeremiah Mahler <jmmahler@gmail.com>
To: Dudley Du <dudley.dulixin@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v14 00/12] input: cyapa: instruction of cyapa patches
Date: Sat, 13 Dec 2014 02:17:53 -0800 [thread overview]
Message-ID: <20141213101753.GA9290@newt.localdomain> (raw)
In-Reply-To: <1418351262-8163-1-git-send-email-dudley.dulixin@gmail.com>
Dudley,
On Fri, Dec 12, 2014 at 10:27:30AM +0800, Dudley Du wrote:
> V14 patches have below updates, details of other updates see history list:
> 1) Correct 9 miss spelling issues of "bufferred" to "buffered".
> 2) Fix the upgrade issue of removing MOUSE_CYAPA config when make oldconfig
> by replase "depends on I2C && CRC_ITU_T" with
> "depends on I2C"
> "select CRC_ITU_T"
> in patch 9.
>
[...]
I found some sparse warnings that should be fixed.
jeri@newt:~/linux-next$ touch drivers/input/mouse/*.c
jeri@newt:~/linux-next$ touch drivers/input/mouse/*.h
jeri@newt:~/linux-next$ make C=1
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
CHK kernel/config_data.h
CHECK drivers/input/mouse/cyapa.c
drivers/input/mouse/cyapa.c:43:9: warning: symbol 'cyapa_i2c_read' was
not declared. Should it be static?
drivers/input/mouse/cyapa.c:80:9: warning: symbol 'cyapa_i2c_write' was
not declared. Should it be static?
drivers/input/mouse/cyapa.c:289:5: warning: symbol 'cyapa_detect' was
not declared. Should it be static?
CC [M] drivers/input/mouse/cyapa.o
CHECK drivers/input/mouse/cyapa_gen3.c
drivers/input/mouse/cyapa_gen3.c:299:5: warning: symbol
'cyapa_read_byte' was not declared. Should it be static?
drivers/input/mouse/cyapa_gen3.c:312:5: warning: symbol
'cyapa_write_byte' was not declared. Should it be static?
drivers/input/mouse/cyapa_gen3.c:331:9: warning: symbol
'cyapa_i2c_reg_write_block' was not declared. Should it be static?
CC [M] drivers/input/mouse/cyapa_gen3.o
CHECK drivers/input/mouse/cyapa_gen5.c
drivers/input/mouse/cyapa_gen5.c:334:5: warning: symbol
'cyapa_empty_pip_output_data' was not declared. Should it be static?
drivers/input/mouse/cyapa_gen5.c:553:6: warning: symbol
'cyapa_gen5_sort_tsg_pip_bl_resp_data' was not declared. Should it be
static?
drivers/input/mouse/cyapa_gen5.c:568:6: warning: symbol
'cyapa_gen5_sort_tsg_pip_app_resp_data' was not declared. Should it be
static?
drivers/input/mouse/cyapa_gen5.c:595:6: warning: symbol
'cyapa_gen5_sort_application_launch_data' was not declared. Should it be
static?
drivers/input/mouse/cyapa_gen5.c:995:6: warning: symbol
'cyapa_gen5_sort_bl_exit_data' was not declared. Should it be static?
drivers/input/mouse/cyapa_gen5.c:1112:72: warning: Using plain integer
as NULL pointer
CC [M] drivers/input/mouse/cyapa_gen5.o
LD [M] drivers/input/mouse/cyapatp.o
Kernel: arch/x86/boot/bzImage is ready (#127)
Building modules, stage 2.
MODPOST 187 modules
CC drivers/input/mouse/cyapatp.mod.o
LDFINAL [M] drivers/input/mouse/cyapatp.ko
jeri@newt:~/linux-next
--
- Jeremiah Mahler
next prev parent reply other threads:[~2014-12-13 10:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 2:27 [PATCH v14 00/12] input: cyapa: instruction of cyapa patches Dudley Du
2014-12-12 2:27 ` [PATCH v14 01/12] input: cyapa: re-design driver to support multi-trackpad in one driver Dudley Du
2014-12-13 11:16 ` Jeremiah Mahler
2014-12-15 3:49 ` Dudley Du
2014-12-12 2:27 ` [PATCH v14 02/12] input: cyapa: add gen5 trackpad device basic functions support Dudley Du
2014-12-12 2:27 ` [PATCH v14 03/12] input: cyapa: add power management interfaces supported for the device Dudley Du
2014-12-12 2:27 ` [PATCH v14 04/12] input: cyapa: add runtime " Dudley Du
2014-12-12 2:27 ` [PATCH v14 05/12] input: cyapa: add sysfs interfaces supported in the cyapa driver Dudley Du
2014-12-12 2:27 ` [PATCH v14 06/12] input: cyapa: add gen3 trackpad device firmware update function support Dudley Du
2014-12-12 2:27 ` [PATCH v14 07/12] input: cyapa: add gen3 trackpad device read baseline " Dudley Du
2014-12-12 2:27 ` [PATCH v14 08/12] input: cyapa: add gen3 trackpad device force re-calibrate " Dudley Du
2014-12-12 2:27 ` [PATCH v14 09/12] input: cyapa: add gen5 trackpad device firmware update " Dudley Du
2014-12-12 2:27 ` [PATCH v14 10/12] input: cyapa: add gen5 trackpad device read baseline " Dudley Du
2014-12-12 2:27 ` [PATCH v14 11/12] input: cyapa: add gen5 trackpad device force re-calibrate " Dudley Du
2014-12-12 2:27 ` [PATCH v14 12/12] input: cyapa: add acpi device id supported Dudley Du
2014-12-13 10:17 ` Jeremiah Mahler [this message]
2014-12-15 3:47 ` [PATCH v14 00/12] input: cyapa: instruction of cyapa patches Dudley Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141213101753.GA9290@newt.localdomain \
--to=jmmahler@gmail.com \
--cc=dudley.dulixin@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).