public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremiah Mahler <jmmahler@gmail.com>
To: Dudley Du <dudley.dulixin@gmail.com>
Cc: dmitry.torokhov@gmail.com, rydberg@euromail.se,
	bleung@google.com, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v15 12/12] input: cyapa: add acpi device id supported
Date: Mon, 15 Dec 2014 06:14:18 -0800	[thread overview]
Message-ID: <20141215141418.GJ918@newt.localdomain> (raw)
In-Reply-To: <1418624603-19054-13-git-send-email-dudley.dulixin@gmail.com>

Dudley,

On Mon, Dec 15, 2014 at 02:23:23PM +0800, Dudley Du wrote:
> Add acpi device tree supported.
                       support.

> acpi device id "CYAP0000" is for old gen3 trackpad devices.
> acpi device id "CYAP0001" is for new gen5 trackpad devices.
> TEST=test on Chromebooks.
> 
> Signed-off-by: Dudley Du <dudley.dulixin@gmail.com>
> ---
>  drivers/input/mouse/cyapa.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c
> index dac3996..9fb97e2 100644
> --- a/drivers/input/mouse/cyapa.c
> +++ b/drivers/input/mouse/cyapa.c
> @@ -24,6 +24,7 @@
>  #include <linux/slab.h>
>  #include <linux/uaccess.h>
>  #include <linux/pm_runtime.h>
> +#include <linux/acpi.h>
>  #include "cyapa.h"
>  
>  
> @@ -1315,11 +1316,23 @@ static const struct i2c_device_id cyapa_id_table[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, cyapa_id_table);
>  
> +#ifdef CONFIG_ACPI
> +static const struct acpi_device_id cyapa_acpi_id[] = {
> +	{ "CYAP0000", 0 },  /* Gen3 trackpad with 0x67 I2C address. */
> +	{ "CYAP0001", 0 },  /* Gen5 trackpad with 0x24 I2C address. */
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(acpi, cyapa_acpi_id);
> +#endif
> +
>  static struct i2c_driver cyapa_driver = {
>  	.driver = {
>  		.name = "cyapa",
>  		.owner = THIS_MODULE,
>  		.pm = &cyapa_pm_ops,
> +#ifdef CONFIG_ACPI
> +		.acpi_match_table = ACPI_PTR(cyapa_acpi_id),
> +#endif
>  	},
>  
>  	.probe = cyapa_probe,
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
- Jeremiah Mahler

  reply	other threads:[~2014-12-15 14:14 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-15  6:23 [PATCH v15 00/12] input: cyapa: instruction of cyapa patches Dudley Du
2014-12-15  6:23 ` [PATCH v15 01/12] input: cyapa: re-design driver to support multi-trackpad in one driver Dudley Du
2014-12-15  6:23 ` [PATCH v15 02/12] input: cyapa: add gen5 trackpad device basic functions support Dudley Du
2014-12-15 14:10   ` Jeremiah Mahler
2014-12-15  6:23 ` [PATCH v15 03/12] input: cyapa: add power management interfaces supported for the device Dudley Du
2014-12-15  6:23 ` [PATCH v15 04/12] input: cyapa: add runtime " Dudley Du
2014-12-15  6:23 ` [PATCH v15 05/12] input: cyapa: add sysfs interfaces supported in the cyapa driver Dudley Du
2014-12-15 14:11   ` Jeremiah Mahler
2014-12-15  6:23 ` [PATCH v15 06/12] input: cyapa: add gen3 trackpad device firmware update function support Dudley Du
2014-12-15 14:11   ` Jeremiah Mahler
2014-12-15  6:23 ` [PATCH v15 07/12] input: cyapa: add gen3 trackpad device read baseline " Dudley Du
2014-12-15 14:11   ` Jeremiah Mahler
2014-12-15  6:23 ` [PATCH v15 08/12] input: cyapa: add gen3 trackpad device force re-calibrate " Dudley Du
2014-12-15 14:12   ` Jeremiah Mahler
2014-12-15  6:23 ` [PATCH v15 09/12] input: cyapa: add gen5 trackpad device firmware update " Dudley Du
2014-12-15 14:12   ` Jeremiah Mahler
2014-12-16 13:56   ` Jeremiah Mahler
2014-12-16 20:24     ` Benson Leung
2014-12-17  1:31       ` Dudley Du
2014-12-17  6:48       ` Jeremiah Mahler
2014-12-17 15:38         ` Benson Leung
2014-12-15  6:23 ` [PATCH v15 10/12] input: cyapa: add gen5 trackpad device read baseline " Dudley Du
2014-12-15 14:13   ` Jeremiah Mahler
2014-12-15  6:23 ` [PATCH v15 11/12] input: cyapa: add gen5 trackpad device force re-calibrate " Dudley Du
2014-12-15  6:23 ` [PATCH v15 12/12] input: cyapa: add acpi device id supported Dudley Du
2014-12-15 14:14   ` Jeremiah Mahler [this message]
2014-12-15  6:31 ` [PATCH v15 00/12] input: cyapa: instruction of cyapa patches Dudley Du
2014-12-15 10:20   ` Jeremiah Mahler
2014-12-15 14:10 ` Jeremiah Mahler
2014-12-16  1:28   ` Dudley Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141215141418.GJ918@newt.localdomain \
    --to=jmmahler@gmail.com \
    --cc=bleung@google.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dudley.dulixin@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rydberg@euromail.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox