From: Jeremiah Mahler <jmmahler@gmail.com>
To: Dudley Du <dudley.dulixin@gmail.com>
Cc: dmitry.torokhov@gmail.com, rydberg@euromail.se,
bleung@google.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v15 09/12] input: cyapa: add gen5 trackpad device firmware update function support
Date: Tue, 16 Dec 2014 05:56:39 -0800 [thread overview]
Message-ID: <20141216135639.GA1238@hudson.localdomain> (raw)
In-Reply-To: <1418624603-19054-10-git-send-email-dudley.dulixin@gmail.com>
Dudley,
On Mon, Dec 15, 2014 at 02:23:20PM +0800, Dudley Du wrote:
> Add firmware image update function supported for gen5 trackpad device,
> it can be used through sysfs update_fw interface.
> TEST=test on Chromebooks.
>
> Signed-off-by: Dudley Du <dudley.dulixin@gmail.com>
> ---
> drivers/input/mouse/Kconfig | 1 +
> drivers/input/mouse/cyapa_gen5.c | 292 ++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 292 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig
> index d8b46b0..728490e 100644
> --- a/drivers/input/mouse/Kconfig
> +++ b/drivers/input/mouse/Kconfig
> @@ -206,6 +206,7 @@ config MOUSE_BCM5974
> config MOUSE_CYAPA
> tristate "Cypress APA I2C Trackpad support"
> depends on I2C
> + select CRC_ITU_T
> help
Just found out that if I2C_DESIGNWARE_PCI isn't enabled the touchpad
won't work. Verify this on your machines. Then perhaps add a depends
for I2C_DESIGNWARE_PCI instead of I2C since it would include the former.
[...]
--
- Jeremiah Mahler
next prev parent reply other threads:[~2014-12-16 13:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 6:23 [PATCH v15 00/12] input: cyapa: instruction of cyapa patches Dudley Du
2014-12-15 6:23 ` [PATCH v15 01/12] input: cyapa: re-design driver to support multi-trackpad in one driver Dudley Du
2014-12-15 6:23 ` [PATCH v15 02/12] input: cyapa: add gen5 trackpad device basic functions support Dudley Du
2014-12-15 14:10 ` Jeremiah Mahler
2014-12-15 6:23 ` [PATCH v15 03/12] input: cyapa: add power management interfaces supported for the device Dudley Du
2014-12-15 6:23 ` [PATCH v15 04/12] input: cyapa: add runtime " Dudley Du
2014-12-15 6:23 ` [PATCH v15 05/12] input: cyapa: add sysfs interfaces supported in the cyapa driver Dudley Du
2014-12-15 14:11 ` Jeremiah Mahler
2014-12-15 6:23 ` [PATCH v15 06/12] input: cyapa: add gen3 trackpad device firmware update function support Dudley Du
2014-12-15 14:11 ` Jeremiah Mahler
2014-12-15 6:23 ` [PATCH v15 07/12] input: cyapa: add gen3 trackpad device read baseline " Dudley Du
2014-12-15 14:11 ` Jeremiah Mahler
2014-12-15 6:23 ` [PATCH v15 08/12] input: cyapa: add gen3 trackpad device force re-calibrate " Dudley Du
2014-12-15 14:12 ` Jeremiah Mahler
2014-12-15 6:23 ` [PATCH v15 09/12] input: cyapa: add gen5 trackpad device firmware update " Dudley Du
2014-12-15 14:12 ` Jeremiah Mahler
2014-12-16 13:56 ` Jeremiah Mahler [this message]
2014-12-16 20:24 ` Benson Leung
2014-12-17 1:31 ` Dudley Du
2014-12-17 6:48 ` Jeremiah Mahler
2014-12-17 15:38 ` Benson Leung
2014-12-15 6:23 ` [PATCH v15 10/12] input: cyapa: add gen5 trackpad device read baseline " Dudley Du
2014-12-15 14:13 ` Jeremiah Mahler
2014-12-15 6:23 ` [PATCH v15 11/12] input: cyapa: add gen5 trackpad device force re-calibrate " Dudley Du
2014-12-15 6:23 ` [PATCH v15 12/12] input: cyapa: add acpi device id supported Dudley Du
2014-12-15 14:14 ` Jeremiah Mahler
2014-12-15 6:31 ` [PATCH v15 00/12] input: cyapa: instruction of cyapa patches Dudley Du
2014-12-15 10:20 ` Jeremiah Mahler
2014-12-15 14:10 ` Jeremiah Mahler
2014-12-16 1:28 ` Dudley Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216135639.GA1238@hudson.localdomain \
--to=jmmahler@gmail.com \
--cc=bleung@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dudley.dulixin@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).