Linux Input/HID development
 help / color / mirror / Atom feed
From: Jeremiah Mahler <jmmahler@gmail.com>
To: Dudley Du <dudlx@outlook.com>
Cc: dmitry.torokhov@gmail.com, rydberg@euromail.se,
	bleung@google.com, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v16 01/12] input: cyapa: re-design driver to support
Date: Wed, 17 Dec 2014 02:14:34 -0800	[thread overview]
Message-ID: <20141217101434.GA2155@newt.localdomain> (raw)
In-Reply-To: <BAY407-EAS4239EB7A931AAE7C4C747F3BD6D0@phx.gbl>

Dudley,

On Wed, Dec 17, 2014 at 05:55:37PM +0800, Dudley Du wrote:
> In order to support multiple different chipsets and communication protocols
> trackpad devices in one cyapa driver, the new cyapa driver is re-designed
> with one cyapa driver core and multiple device specific functions component.
> The cyapa driver core is contained in this patch, it supplies basic functions
[...]
> +
> +	.set_power_mode = cyapa_gen3_set_power_mode,
> +};
> -- 
> 1.9.1
> 

Unfortunately this patch and the others do not apply.

  Patch failed at 0001 input: cyapa: re-design driver to support
  The copy of the patch that failed is found in:
     /home/jeri/linux-next/.git/rebase-apply/patch
  When you have resolved this problem, run "git am --continue".
  If you prefer to skip this patch, run "git am --skip" instead.
  To restore the original branch and stop patching, run "git am
  --abort".

It looks like your mailer may have done some line wrapping that
messed up the patches.

  ...
  -       { CYAPA_SMBUS_BLK_HEAD, 16 },
  -};
  +static int cyapa_reinitialize(struct cyapa *cyapa);
   
  -static ssize_t cyapa_i2c_reg_read_block(struct cyapa *cyapa, u8 reg,
  size_t
  len,
  +/* Returns 0 on success, else negative errno on failure. */
  +static ssize_t cyapa_i2c_read(struct cyapa *cyapa, u8 reg, size_t len,
                                          u8 *values)
   {
  -     
  ...

linux/Documentation/email-clients.txt has good information about these
problems.

-- 
- Jeremiah Mahler

  reply	other threads:[~2014-12-17 10:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-17  9:55 [PATCH v16 01/12] input: cyapa: re-design driver to support Dudley Du
2014-12-17 10:14 ` Jeremiah Mahler [this message]
2014-12-17 10:55   ` Dudley Du
2014-12-17 12:17     ` Jeremiah Mahler
     [not found]       ` <BAY176-W39AFAEB1037657BD495F30BD6D0@phx.gbl>
2014-12-17 15:04         ` Jeremiah Mahler
2014-12-18  1:45           ` Dudley Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141217101434.GA2155@newt.localdomain \
    --to=jmmahler@gmail.com \
    --cc=bleung@google.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dudlx@outlook.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rydberg@euromail.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox