Re: [PATCH] input: adxl34x: Add OF match support

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

On Thu, Dec 18, 2014 at 04:15:23AM +0200, Laurent Pinchart wrote:
> The I2C subsystem can match devices without explicit OF support based on
> the part of their compatible property after the comma. However, this
> mechanism uses the first compatible value only. For adxl34x OF device
> nodes the compatible property should list the more specific
> "adi,adxl345" or "adi,adxl346" value first and the "adi,adxl34x"
> fallback value second. This prevents the device node from being matched
> with the adxl34x driver.
> 
> Fix this by adding an OF match table with an "adi,adxl34x" compatible
> entry.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  drivers/input/misc/adxl34x-i2c.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> Another option would have been to add "adxl325" and "adxl326" entries to the
> adxl34x_id I2C match table, but it would have had the drawback of requiring a
> driver update for every new device.

AFAIK this is even required for compatible entries, to be as specific as
possible. I think this makes sense. With platform_ids, we already had
the problem that pca954x was too generic and was used for both GPIO
extenders and I2C muxers (IIRC).


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]