From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Helge Deller <deller@gmx.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-input@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/13] incorrect use of init_completion fixup
Date: Fri, 26 Dec 2014 15:42:39 -0800 [thread overview]
Message-ID: <20141226234239.GB1071@dtor-ws> (raw)
In-Reply-To: <1419581170-5182-1-git-send-email-der.herr@hofr.at>
On Fri, Dec 26, 2014 at 09:06:10AM +0100, Nicholas Mc Guire wrote:
> The successive init_completion calls should be reinit_completion calls.
>
> patch against 3.19.0-rc1 linux-next
>
> Acked-by: Helge Deller <deller@gmx.de>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
Applied, thank you.
> ---
> drivers/input/keyboard/hil_kbd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/keyboard/hil_kbd.c b/drivers/input/keyboard/hil_kbd.c
> index 610a8af..5b152f2 100644
> --- a/drivers/input/keyboard/hil_kbd.c
> +++ b/drivers/input/keyboard/hil_kbd.c
> @@ -473,7 +473,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
> if (error)
> goto bail1;
>
> - init_completion(&dev->cmd_done);
> + reinit_completion(&dev->cmd_done);
> serio_write(serio, 0);
> serio_write(serio, 0);
> serio_write(serio, HIL_PKT_CMD >> 8);
> @@ -482,7 +482,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
> if (error)
> goto bail1;
>
> - init_completion(&dev->cmd_done);
> + reinit_completion(&dev->cmd_done);
> serio_write(serio, 0);
> serio_write(serio, 0);
> serio_write(serio, HIL_PKT_CMD >> 8);
> @@ -491,7 +491,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
> if (error)
> goto bail1;
>
> - init_completion(&dev->cmd_done);
> + reinit_completion(&dev->cmd_done);
> serio_write(serio, 0);
> serio_write(serio, 0);
> serio_write(serio, HIL_PKT_CMD >> 8);
> --
> 1.7.10.4
>
--
Dmitry
prev parent reply other threads:[~2014-12-26 23:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-26 8:06 [PATCH 4/13] incorrect use of init_completion fixup Nicholas Mc Guire
2014-12-26 23:42 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141226234239.GB1071@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=deller@gmx.de \
--cc=der.herr@hofr.at \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).