* [PATCH 4/13] incorrect use of init_completion fixup
@ 2014-12-26 8:06 Nicholas Mc Guire
2014-12-26 23:42 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Mc Guire @ 2014-12-26 8:06 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Helge Deller, Paul Gortmaker, linux-input, linux-parisc,
linux-kernel, Nicholas Mc Guire
The successive init_completion calls should be reinit_completion calls.
patch against 3.19.0-rc1 linux-next
Acked-by: Helge Deller <deller@gmx.de>
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
drivers/input/keyboard/hil_kbd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/keyboard/hil_kbd.c b/drivers/input/keyboard/hil_kbd.c
index 610a8af..5b152f2 100644
--- a/drivers/input/keyboard/hil_kbd.c
+++ b/drivers/input/keyboard/hil_kbd.c
@@ -473,7 +473,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
if (error)
goto bail1;
- init_completion(&dev->cmd_done);
+ reinit_completion(&dev->cmd_done);
serio_write(serio, 0);
serio_write(serio, 0);
serio_write(serio, HIL_PKT_CMD >> 8);
@@ -482,7 +482,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
if (error)
goto bail1;
- init_completion(&dev->cmd_done);
+ reinit_completion(&dev->cmd_done);
serio_write(serio, 0);
serio_write(serio, 0);
serio_write(serio, HIL_PKT_CMD >> 8);
@@ -491,7 +491,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
if (error)
goto bail1;
- init_completion(&dev->cmd_done);
+ reinit_completion(&dev->cmd_done);
serio_write(serio, 0);
serio_write(serio, 0);
serio_write(serio, HIL_PKT_CMD >> 8);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/13] incorrect use of init_completion fixup
2014-12-26 8:06 [PATCH 4/13] incorrect use of init_completion fixup Nicholas Mc Guire
@ 2014-12-26 23:42 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2014-12-26 23:42 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: Helge Deller, Paul Gortmaker, linux-input, linux-parisc,
linux-kernel
On Fri, Dec 26, 2014 at 09:06:10AM +0100, Nicholas Mc Guire wrote:
> The successive init_completion calls should be reinit_completion calls.
>
> patch against 3.19.0-rc1 linux-next
>
> Acked-by: Helge Deller <deller@gmx.de>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
Applied, thank you.
> ---
> drivers/input/keyboard/hil_kbd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/keyboard/hil_kbd.c b/drivers/input/keyboard/hil_kbd.c
> index 610a8af..5b152f2 100644
> --- a/drivers/input/keyboard/hil_kbd.c
> +++ b/drivers/input/keyboard/hil_kbd.c
> @@ -473,7 +473,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
> if (error)
> goto bail1;
>
> - init_completion(&dev->cmd_done);
> + reinit_completion(&dev->cmd_done);
> serio_write(serio, 0);
> serio_write(serio, 0);
> serio_write(serio, HIL_PKT_CMD >> 8);
> @@ -482,7 +482,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
> if (error)
> goto bail1;
>
> - init_completion(&dev->cmd_done);
> + reinit_completion(&dev->cmd_done);
> serio_write(serio, 0);
> serio_write(serio, 0);
> serio_write(serio, HIL_PKT_CMD >> 8);
> @@ -491,7 +491,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
> if (error)
> goto bail1;
>
> - init_completion(&dev->cmd_done);
> + reinit_completion(&dev->cmd_done);
> serio_write(serio, 0);
> serio_write(serio, 0);
> serio_write(serio, HIL_PKT_CMD >> 8);
> --
> 1.7.10.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-26 23:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-26 8:06 [PATCH 4/13] incorrect use of init_completion fixup Nicholas Mc Guire
2014-12-26 23:42 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).