From: Jeremiah Mahler <jmmahler@gmail.com>
To: Dudley Du <dudl@cypress.com>
Cc: dmitry.torokhov@gmail.com, rydberg@euromail.se,
bleung@google.com, dso@cypress.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v17 00/12] input: cyapa: instruction of cyapa patches
Date: Wed, 31 Dec 2014 08:11:20 -0800 [thread overview]
Message-ID: <20141231161120.GA1385@newt.localdomain> (raw)
In-Reply-To: <1419988621-2919-1-git-send-email-dudl@cypress.com>
Dudley,
On Wed, Dec 31, 2014 at 09:16:49AM +0800, Dudley Du wrote:
> V17 patches have below updates, details of other updates see history list:
> 1) Fix kernel oops when system booting up with finger on TP.
> 2) Remove unnecessary error log that may to system.
> 3) Slipt out pm sleep code into cyapa_prepare_wakeup_controls(),
> remove #indefs in function body of CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.
> 4) Supply stubs to cyapa_gen3_ops and cyapa_gen5_ops data structure to avoid
> checking for presence of various methods in ops.
> 6) Fix the meanings of some comments and return error code not clear issue.
[...]
It has build errors :(
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
CHK kernel/config_data.h
CC [M] drivers/input/mouse/cyapa.o
In file included from include/linux/device.h:25:0,
from include/linux/i2c.h:30,
from drivers/input/mouse/cyapa.c:18:
drivers/input/mouse/cyapa.c:1339:21: error: ‘cyapa_runtime_suspend’ undeclared here (not in a function)
SET_RUNTIME_PM_OPS(cyapa_runtime_suspend, cyapa_runtime_resume, NULL)
^
include/linux/pm.h:347:21: note: in definition of macro ‘SET_RUNTIME_PM_OPS’
.runtime_suspend = suspend_fn, \
^
drivers/input/mouse/cyapa.c:1339:44: error: ‘cyapa_runtime_resume’ undeclared here (not in a function)
SET_RUNTIME_PM_OPS(cyapa_runtime_suspend, cyapa_runtime_resume, NULL)
^
include/linux/pm.h:348:20: note: in definition of macro ‘SET_RUNTIME_PM_OPS’
.runtime_resume = resume_fn, \
^
scripts/Makefile.build:257: recipe for target 'drivers/input/mouse/cyapa.o' failed
make[3]: *** [drivers/input/mouse/cyapa.o] Error 1
scripts/Makefile.build:402: recipe for target 'drivers/input/mouse' failed
make[2]: *** [drivers/input/mouse] Error 2
scripts/Makefile.build:402: recipe for target 'drivers/input' failed
make[1]: *** [drivers/input] Error 2
make[1]: *** Waiting for unfinished jobs....
Makefile:955: recipe for target 'drivers' failed
make: *** [drivers] Error 2
make: *** Waiting for unfinished jobs....
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-12-31 16:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 1:16 [PATCH v17 00/12] input: cyapa: instruction of cyapa patches Dudley Du
2014-12-31 1:16 ` [PATCH v17 01/12] input: cyapa: re-design driver to support multi-trackpad in one driver Dudley Du
2014-12-31 1:16 ` [PATCH v17 02/12] input: cyapa: add gen5 trackpad device basic functions support Dudley Du
2014-12-31 1:16 ` [PATCH v17 03/12] input: cyapa: add power management interfaces support for the device Dudley Du
2014-12-31 1:16 ` [PATCH v17 04/12] input: cyapa: add runtime " Dudley Du
2014-12-31 1:16 ` [PATCH v17 05/12] input: cyapa: add sysfs interfaces support in the cyapa driver Dudley Du
2014-12-31 1:16 ` [PATCH v17 06/12] input: cyapa: add gen3 trackpad device firmware update function support Dudley Du
2014-12-31 1:16 ` [PATCH v17 07/12] input: cyapa: add gen3 trackpad device read baseline " Dudley Du
2014-12-31 1:16 ` [PATCH v17 08/12] input: cyapa: add gen3 trackpad device force re-calibrate " Dudley Du
2014-12-31 1:16 ` [PATCH v17 09/12] input: cyapa: add gen5 trackpad device firmware update " Dudley Du
2014-12-31 1:16 ` [PATCH v17 10/12] input: cyapa: add gen5 trackpad device read baseline " Dudley Du
2014-12-31 1:17 ` [PATCH v17 11/12] input: cyapa: add gen5 trackpad device force re-calibrate " Dudley Du
2014-12-31 1:17 ` [PATCH v17 12/12] input: cyapa: add acpi device id support Dudley Du
2014-12-31 16:11 ` Jeremiah Mahler [this message]
2015-01-05 1:57 ` [PATCH v17 00/12] input: cyapa: instruction of cyapa patches Dudley Du
2015-01-14 1:34 ` Dudley Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141231161120.GA1385@newt.localdomain \
--to=jmmahler@gmail.com \
--cc=bleung@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dso@cypress.com \
--cc=dudl@cypress.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).