From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v3 4/9] ARM: dts: sun7i: cubieboard2: add axp209 regulator nodes Date: Tue, 13 Jan 2015 10:40:36 +0100 Message-ID: <20150113094036.GR4891@lukather> References: <1421037249-28461-1-git-send-email-wens@csie.org> <1421037249-28461-5-git-send-email-wens@csie.org> <20150112090603.GE4891@lukather> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qOEfHYdX8LquYLAx" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org To: Chen-Yu Tsai Cc: Dmitry Torokhov , Zhang Rui , Eduardo Valentin , Hans de Goede , "linux-input@vger.kernel.org" , linux-arm-kernel , linux-pm@vger.kernel.org List-Id: linux-input@vger.kernel.org --qOEfHYdX8LquYLAx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Jan 12, 2015 at 05:38:12PM +0800, Chen-Yu Tsai wrote: > Hi, >=20 > On Mon, Jan 12, 2015 at 5:06 PM, Maxime Ripard > wrote: > > Hi Chen-Yu, > > > > On Mon, Jan 12, 2015 at 12:34:04PM +0800, Chen-Yu Tsai wrote: > >> This patch adds the regulator nodes for the axp209 by including > >> the axp209 dtsi. As the inputs of these regulators are from the > >> axp209's PS output, which is basically just a mux over the 2 > >> inputs, it is considered to be unregulated. Thus we do not provide > >> input supply properties for them. > >> > >> The regulator names and constraints are based on the board > >> schematics and the SoC datasheet. > >> > >> DCDC2 is used as the cpu power supply. This patch also references > >> it from the cpu node. > >> > >> Also get rid of axp209 properties already set in axp209.dtsi. > >> > >> Signed-off-by: Chen-Yu Tsai > >> --- > >> > >> changes since v2 > >> > >> none > >> > >> changes since v1: > >> > >> - Use preprocessor include for axp209.dtsi > >> - Remove incorrectly squashed axp209.dtsi patch > >> > >> --- > >> arch/arm/boot/dts/sun7i-a20-cubieboard2.dts | 35 ++++++++++++++++++++= +++++---- > >> 1 file changed, 31 insertions(+), 4 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/sun7i-a20-cubieboard2.dts b/arch/arm/bo= ot/dts/sun7i-a20-cubieboard2.dts > >> index 18fc5db9c976..ec1fc2c8b3e3 100644 > >> --- a/arch/arm/boot/dts/sun7i-a20-cubieboard2.dts > >> +++ b/arch/arm/boot/dts/sun7i-a20-cubieboard2.dts > >> @@ -88,13 +88,9 @@ > >> status =3D "okay"; > >> > >> axp209: pmic@34 { > >> - compatible =3D "x-powers,axp209"; > >> reg =3D <0x34>; > >> interrupt-parent =3D <&nmi_intc>; > >> interrupts =3D <0 IRQ_TYPE_LEVEL_LOW>; > >> - > >> - interrupt-controller; > >> - #interrupt-cells =3D <1>; > >> }; > >> }; > >> > >> @@ -145,3 +141,34 @@ > >> status =3D "okay"; > >> }; > >> }; > >> + > >> +#include "axp209.dtsi" > >> + > >> +&cpu0 { > >> + cpu-supply =3D <®_dcdc2>; > >> +}; > >> + > >> +®_dcdc2 { > >> + regulator-always-on; > >> + regulator-min-microvolt =3D <1000000>; > >> + regulator-max-microvolt =3D <1450000>; > >> + regulator-name =3D "vdd-cpu"; > >> +}; > >> + > >> +®_dcdc3 { > >> + regulator-always-on; > >> + regulator-min-microvolt =3D <1000000>; > >> + regulator-max-microvolt =3D <1400000>; > >> + regulator-name =3D "vdd-int-dll"; > >> +}; > >> + > >> +®_ldo1 { > >> + regulator-name =3D "vdd-rtc"; > >> +}; > >> + > >> +®_ldo2 { > >> + regulator-always-on; > >> + regulator-min-microvolt =3D <3000000>; > >> + regulator-max-microvolt =3D <3000000>; > >> + regulator-name =3D "avcc"; > >> +}; > > > > How do reg_vcc3v3 and the other reg used in this DT (ahci, USB) fit > > into that? >=20 > The following applies to boards that use AXP209. >=20 > reg_vcc3v3 or reg_vcc3v0 is an external buck regulator with it's > enable pin tied to EXTEN on the AXP. This pin is controllable, > but we do not have the driver for it. It is possible that multiple > regulators are tied to this pin. I suggest not touching it without > the correct schematics. >=20 > The source for usb and ahci regulators, or reg_vcc5v if you will, > is either the unregulated 5v from the power supply or the usb otg > port. For the Cubietruck, there's an additional uncontrollable > boost regulator that boosts the lipo battery's power up to 5v. >=20 > On some of the Olimex boards that use higher input voltages, they > use an uncontrollable buck regulator to step down the voltage to > 5v. The Olinuxino-Micro also has a boost regulator for the battery, > tied to EXTEN. >=20 > The AXP209 simply does not have enough outputs for all the needed > voltages. Hmm, yes, ok. It makes sense. > You could probably chain the regulators in the DT via xxx-supply > if it helps. But beyond that, it is hard to do anything meaningful > at this point. Modeling them as fixed regulators beyond our control > is simpler. We also do not have an IPSOUT regulator for the AXP. >=20 > > Eventually, I think we would be able to remove > > sunxi-common-regulators.dtsi, or at least, expose the proper regulator > > hierarchy. >=20 > The USB and SATA regulators are just GPIO enabled switches (MOSFETs) > or current limiters. I think these will always exist because of the > reference designs. Or do you want to move them back into the board > dts files? FWIW, I like it the way it is now. Not that I don't like > it to be accurate. At least providing the right hierarchy at the board level would be great. Adding the -supply property to all our fixed regulators wouldn't take too much code, and would be enough to model properly the regulator trees. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --qOEfHYdX8LquYLAx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUtOgUAAoJEBx+YmzsjxAge6sP/iRiK651y5ZbYpJLR48V5GPR O2Eqi6Gv8nMg1iZVhh7Alq6UJUUwxzslHzP6ffe+DEWe3EhEFgiEDQ2c/8ZW96f5 AaKTXSDNtlV4+mxLRhmWYFeIkGxSiCKhOToUjPCwXB77sm0ra2N0zA2TGwO2451h 9WTnNtKKJcWaZDM8Ijed2wju5eX90OXuYwr2o455Sbx94CqAL66iw+ToWuuwVDMb YOCdT/cux84lyf9UYQC6hBRSA9dgRqjUuxFVUzmj236MnDVxAvxu5lhZz6fxykiU FgteEqgo1i+aDh4XNJaDfDUi+NRJbcPardmJ6yGgtbBZMGvH8FYQWmte/DAZx2TQ ix7WrE/SLVBbUt1VtO7PL5gbb6lqfg9UfD+NNJVtQkNR79w8YwrvxjuSzfPB1mWn ZAxTXndbATrMdqYL9zAEjz37TbXg+YOwohspyBW+DXthYm1VEhxvDkSQ632xG7bm BYAi3Jz1MhJ70qDPuYizQFmGs9glTmhTiLWYnZU/3mzaR1ZdWCRnD0FWcCxSPipl 72j64FQjKsgRB0C0JAzACpXna8hm64Ejol0ahgaewaPZc9QIf7wFitOsw4gYHoSX vqIytz+OJliWQkDaZGtfgR2TqqhAxhm6yihd2e130CQohfwgQOfZnm6uBiY26+Fz Zlen5H8K50XQkqqsrTIk =SOCK -----END PGP SIGNATURE----- --qOEfHYdX8LquYLAx--