From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation Date: Thu, 15 Jan 2015 10:16:37 -0800 Message-ID: <20150115181637.GE33214@dtor-ws> References: <1412108254-19234-1-git-send-email-marek@goldelico.com> <1412108254-19234-2-git-send-email-marek@goldelico.com> <20150115005938.GB9134@dtor-ws> <0F9A17C1-9B01-4EE9-BE98-266B8FC02B84@goldelico.com> <20150115143855.GD512@earth.universe> <8B08216C-13DD-40D8-9BA9-060F1C18A018@goldelico.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ie0-f172.google.com ([209.85.223.172]:36471 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752936AbbAOSQn (ORCPT ); Thu, 15 Jan 2015 13:16:43 -0500 Content-Disposition: inline In-Reply-To: <8B08216C-13DD-40D8-9BA9-060F1C18A018@goldelico.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: "Dr. H. Nikolaus Schaller" Cc: Sebastian Reichel , Belisko Marek , Rob Herring , Pawel Moll , Mark Rutland , "ijc+devicetree@hellion.org.uk" , Kumar Gala , Benoit Cousson , Tony Lindgren , Russell King - ARM Linux , "devicetree@vger.kernel.org" , LKML , "linux-omap@vger.kernel.org" , linux-arm-kernel , linux-input@vger.kernel.org, Marek Belisko , Jonathan Richardson , Scott Branden , Yoichi Yuasa , Maxime Ripard , List On Thu, Jan 15, 2015 at 05:14:38PM +0100, Dr. H. Nikolaus Schaller wrot= e: >=20 > Am 15.01.2015 um 15:38 schrieb Sebastian Reichel : >=20 > > Hi, > >=20 > > On Thu, Jan 15, 2015 at 08:36:44AM +0100, Dr. H. Nikolaus Schaller = wrote: > >>> 1. Perform conversion in input core rather than individual driver= s. I > >>> think we should allocate a new bitmaps for some transformations a= nd have > >>> the code do X/Y flip/clip of the coordinates. > >>=20 > >> Do you have a suggestion where this should be (I have no clue how > >> the input system works or is structured - we just know how to exte= nd a > >> driver that uses it)? > >>=20 > >>> 2. Standardize on bindings. We already have of-touchscreen.c doin= g > >>> rudimentary parsing, we shoudl look into extending it rather than > >>> creating myriad of driver-specific bindings. > >>=20 > >> Ok, looks reasonable. > >=20 > > Documentation is in=20 > >=20 > > Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt >=20 > I did look into it now. Unfortunately, it does not fit well into my v= iew of how bindings > should be. They should describe hardware (as we are told for many oth= er kernel > subsystems). >=20 > Pixels and resolutions are IMHO related to the screen it is glued on = - and that is > quite independent. Well, I think pixels was the wrong word to be used there. It is meant t= o be native units, as opposed to millimeters, inches, points, etc. >=20 > So I don=E2=80=99t see how they do describe the different ways the to= uch screen can be > wired to a tsc2007 controller. >=20 > Please can you add minimum and maximum properties for us? >=20 > Then, inverted-x and inverted-y is redundant because it is the same a= s having > an expected higher value from the ADC for the minimum coordinate and = a lower > for the maximum. I'd rather not add minimum and maximum, but add the touchscreen-start-x= and touchscreen-start-y instead so that we limit the number of obsolete properties. Thanks. --=20 Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html