From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Antonio Ospite <ao2@ao2.it>
Cc: Shailendra Verma <shailendra.capricorn@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/9] Fixed indentation violation in switch statement : Aligned the "switch" and its subordinate "case" labels in the same column instead of "double-intending" the "case" labels.
Date: Sat, 17 Jan 2015 14:15:17 -0800 [thread overview]
Message-ID: <20150117221517.GB38334@dtor-ws> (raw)
In-Reply-To: <20150117161316.66645bebb64e7f46218d7daa@ao2.it>
On Sat, Jan 17, 2015 at 04:13:16PM +0100, Antonio Ospite wrote:
> On Sat, 17 Jan 2015 17:23:45 +0530
> Shailendra Verma <shailendra.capricorn@gmail.com> wrote:
>
> >
> > Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> > ---
> > drivers/input/evdev.c | 30 ++++++++++++++++++++----------
> > drivers/input/mousedev.c | 18 ++++++++++++------
> > 2 files changed, 32 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
> > index 18d4b2c..85ee594 100644
> > --- a/drivers/input/evdev.c
> > +++ b/drivers/input/evdev.c
> > @@ -667,16 +667,26 @@ static int handle_eviocgbit(struct input_dev *dev,
> >
> > switch (type) {
> >
> > - case 0: bits = dev->evbit; len = EV_MAX; break;
> > - case EV_KEY: bits = dev->keybit; len = KEY_MAX; break;
> > - case EV_REL: bits = dev->relbit; len = REL_MAX; break;
> > - case EV_ABS: bits = dev->absbit; len = ABS_MAX; break;
> > - case EV_MSC: bits = dev->mscbit; len = MSC_MAX; break;
> > - case EV_LED: bits = dev->ledbit; len = LED_MAX; break;
> > - case EV_SND: bits = dev->sndbit; len = SND_MAX; break;
> > - case EV_FF: bits = dev->ffbit; len = FF_MAX; break;
> > - case EV_SW: bits = dev->swbit; len = SW_MAX; break;
> > - default: return -EINVAL;
>
> I have the feeling this formatting was deliberate, to make comparing the
> lines easier, see the alignment after colons and semicolons.
Yes, I'd rather kept the code here and in mousedev as is.
Thanks.
--
Dmitry
prev parent reply other threads:[~2015-01-17 22:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 11:53 [PATCH 8/9] Fixed indentation violation in switch statement : Aligned the "switch" and its subordinate "case" labels in the same column instead of "double-intending" the "case" labels Shailendra Verma
2015-01-17 15:13 ` Antonio Ospite
2015-01-17 22:15 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150117221517.GB38334@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=ao2@ao2.it \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shailendra.capricorn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox