From: Lee Jones <lee.jones@linaro.org>
To: "R, Vignesh" <vigneshr@ti.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Samuel Ortiz <sameo@linux.intel.com>,
Brad Griffis <bgriffis@ti.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Sanjeev Sharma <sanjeev_sharma@mentor.com>,
Jan Kardell <jan.kardell@telliq.com>, Felipe Balbi <balbi@ti.com>,
Wolfram Sang <wsa@the-dreams.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.
Subject: Re: [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save
Date: Tue, 20 Jan 2015 16:04:10 +0000 [thread overview]
Message-ID: <20150120160410.GL13701@x1> (raw)
In-Reply-To: <54BE4CD1.1020709@ti.com>
On Tue, 20 Jan 2015, R, Vignesh wrote:
> On 1/20/2015 5:23 PM, Lee Jones wrote:
> > On Wed, 07 Jan 2015, Vignesh R wrote:
> >
> >> In one shot mode, sequencer automatically disables all enabled steps at
> >> the end of each cycle. (both ADC steps and TSC steps) Hence these steps
> >> need not be saved in reg_se_cache for clearing these steps at a later
> >> stage.
> >> Also, when ADC wakes up Sequencer should not be busy executing any of the
> >> config steps except for the charge step. Previously charge step was 1 ADC
> >> clock cycle and hence it was ignored.
> >> TSC steps are always disabled at the end of each conversion cycle, hence
> >> there is no need to explicitly disable TSC steps by writing 0 to REG_SE.
> >>
> >> Signed-off-by: Vignesh R <vigneshr@ti.com>
> >> ---
> >>
> >> v5:
> >> - Remove unnecessary clearing of REG_SE
> >>
> >> drivers/mfd/ti_am335x_tscadc.c | 13 +++++--------
> >> include/linux/mfd/ti_am335x_tscadc.h | 1 +
> >> 2 files changed, 6 insertions(+), 8 deletions(-)
> >
> > Looks fine.
> >
> > For my own reference:
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> >
> > Can this patch be applied on its own?
> >
>
> I prefer to wait until input patches are picked up.
I have no problem with that, but is there a technical reason why?
> >> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
> >> index 467c80e1c4ae..e4e4b22eebc9 100644
> >> --- a/drivers/mfd/ti_am335x_tscadc.c
> >> +++ b/drivers/mfd/ti_am335x_tscadc.c
> >> @@ -68,12 +68,6 @@ static void am335x_tscadc_need_adc(struct ti_tscadc_dev *tsadc)
> >> DEFINE_WAIT(wait);
> >> u32 reg;
> >>
> >> - /*
> >> - * disable TSC steps so it does not run while the ADC is using it. If
> >> - * write 0 while it is running (it just started or was already running)
> >> - * then it completes all steps that were enabled and stops then.
> >> - */
> >> - tscadc_writel(tsadc, REG_SE, 0);
> >> reg = tscadc_readl(tsadc, REG_ADCFSM);
> >> if (reg & SEQ_STATUS) {
> >> tsadc->adc_waiting = true;
> >> @@ -86,8 +80,12 @@ static void am335x_tscadc_need_adc(struct ti_tscadc_dev *tsadc)
> >> spin_lock_irq(&tsadc->reg_lock);
> >> finish_wait(&tsadc->reg_se_wait, &wait);
> >>
> >> + /*
> >> + * Sequencer should either be idle or
> >> + * busy applying the charge step.
> >> + */
> >> reg = tscadc_readl(tsadc, REG_ADCFSM);
> >> - WARN_ON(reg & SEQ_STATUS);
> >> + WARN_ON((reg & SEQ_STATUS) && !(reg & CHARGE_STEP));
> >> tsadc->adc_waiting = false;
> >> }
> >> tsadc->adc_in_use = true;
> >> @@ -96,7 +94,6 @@ static void am335x_tscadc_need_adc(struct ti_tscadc_dev *tsadc)
> >> void am335x_tsc_se_set_once(struct ti_tscadc_dev *tsadc, u32 val)
> >> {
> >> spin_lock_irq(&tsadc->reg_lock);
> >> - tsadc->reg_se_cache |= val;
> >> am335x_tscadc_need_adc(tsadc);
> >>
> >> tscadc_writel(tsadc, REG_SE, val);
> >> diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h
> >> index 3f4e994ace2b..1fd50dcfe47c 100644
> >> --- a/include/linux/mfd/ti_am335x_tscadc.h
> >> +++ b/include/linux/mfd/ti_am335x_tscadc.h
> >> @@ -128,6 +128,7 @@
> >>
> >> /* Sequencer Status */
> >> #define SEQ_STATUS BIT(5)
> >> +#define CHARGE_STEP 0x11
> >>
> >> #define ADC_CLK 3000000
> >> #define TOTAL_STEPS 16
> >
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-20 16:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 5:49 [PATCH v6 0/6] Touchscreen performance related fixes Vignesh R
2015-01-07 5:49 ` [PATCH v6 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Vignesh R
2015-01-07 5:49 ` [PATCH v6 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R
2015-01-30 5:26 ` Vignesh R
[not found] ` <54CB1604.9030709-l0cyMroinI0@public.gmane.org>
2015-02-03 19:49 ` Dmitry Torokhov
2015-01-07 5:49 ` [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save Vignesh R
[not found] ` <1420609779-11156-4-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2015-01-20 11:53 ` Lee Jones
2015-01-20 12:40 ` R, Vignesh
2015-01-20 16:04 ` Lee Jones [this message]
2015-01-21 10:14 ` Vignesh R
2015-02-05 6:21 ` Vignesh R
[not found] ` <54D30BE5.4070906-l0cyMroinI0@public.gmane.org>
2015-02-25 4:07 ` Vignesh R
2015-02-25 7:17 ` Lee Jones
2015-01-07 5:49 ` [PATCH v6 4/6] input: touchscreen: ti_am335x_tsc: Read charge delay from DT Vignesh R
2015-01-07 5:49 ` [PATCH v6 5/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC Vignesh R
2015-01-07 5:49 ` [PATCH v6 6/6] input: touchscreen: ti_am335x_tsc: Replace delta filtering with median filtering Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150120160410.GL13701@x1 \
--to=lee.jones@linaro.org \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=bgriffis@ti.com \
--cc=bigeasy@linutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jan.kardell@telliq.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger. \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=paul.gortmaker@windriver.com \
--cc=pawel.moll@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=sanjeev_sharma@mentor.com \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).