From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Mika Westerberg <mika.westerberg@intel.com>
Cc: Antonio Ospite <ao2@ao2.it>,
linux-input@vger.kernel.org, linux-acpi@vger.kernel.org,
Bastien Nocera <hadess@hadess.net>,
Mathias Nyman <mathias.nyman@linux.intel.com>
Subject: Re: About Goodix-TS on Bay Trail, and ACPI and interrupts
Date: Tue, 20 Jan 2015 11:31:52 -0500 [thread overview]
Message-ID: <20150120163152.GB23441@mail.corp.redhat.com> (raw)
In-Reply-To: <20150120100548.GG1850@lahna.fi.intel.com>
On Jan 20 2015 or thereabouts, Mika Westerberg wrote:
> On Mon, Jan 19, 2015 at 10:37:58AM -0500, Benjamin Tissoires wrote:
> > Hi Antonio,
> >
> > [adding Mika in CC, he implemented most of the ACPI and GPIO for
> > i2c-hid]
> >
> > On Jan 17 2015 or thereabouts, Antonio Ospite wrote:
> > > Hi,
> > >
> > > I am trying to make the Goodix driver (drivers/input/touchscreen/goodix.c)
> > > working with a Teclast X98 Air 3G, a tablet based on Intel Bay Trail,
> > > but I am new to ACPI and I could use some help.
> > >
> > > I am working with a 3.19-rc4 kernel compiled for x86_64.
> > >
> > > This is the DSDT section in the UEFI firmware:
> > >
> > > Device (TCS0)
> > > {
> > > Name (_ADR, Zero) // _ADR: Address
> > > Name (_HID, "GODX0911") // _HID: Hardware ID
> > > Name (_CID, "PNP0C50" /* HID Protocol Device (I2C bus) */) // _CID: Compatible ID
> >
> > urgh, this is bad. It declares itself as i2c-hid, but it is not :(
> > Anyway, according to your logs, i2c-hid probe() just fails, so it's not
> > a big problem.
>
>
> Actually, I think this device should use i2c-hid. All the ACPI plumbing
> is there including _DSM.
>
> What makes you think it should use the goodix driver?
The fact that the 3.19-rc4 log says:
[ 2.424370] i2c_hid i2c-GODX0911:01: unexpected HID descriptor bcdVersion (0x0000)
Which is rather troublesome and shows that we might have received a 0
answer when requesting the HID descriptor. Then Antonio tried to poke
the device with the goodix driver and got a better answer from the
version point of view.
Cheers,
Benjamin
next prev parent reply other threads:[~2015-01-20 16:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 0:03 About Goodix-TS on Bay Trail, and ACPI and interrupts Antonio Ospite
2015-01-19 15:37 ` Benjamin Tissoires
2015-01-20 10:05 ` Mika Westerberg
2015-01-20 16:31 ` Benjamin Tissoires [this message]
2015-01-21 10:09 ` Mika Westerberg
2015-01-20 16:56 ` Antonio Ospite
2015-01-21 10:16 ` Mika Westerberg
2015-01-27 14:45 ` Antonio Ospite
2015-02-06 16:00 ` Antonio Ospite
2015-02-09 13:25 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150120163152.GB23441@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=ao2@ao2.it \
--cc=hadess@hadess.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=mika.westerberg@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).