From: Jeremiah Mahler <jmmahler@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dudley Du <dudl@cypress.com>,
dmitry.torokhov@gmail.com, rydberg@euromail.se,
bleung@google.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] input: cyapa: fix sparse warning issue of incorrect type in assiggment
Date: Fri, 23 Jan 2015 01:50:26 -0800 [thread overview]
Message-ID: <20150123095026.GA9314@hudson.localdomain> (raw)
In-Reply-To: <20150122095453.GL6507@mwanda>
On Thu, Jan 22, 2015 at 12:54:53PM +0300, Dan Carpenter wrote:
> On Thu, Jan 22, 2015 at 01:31:29AM -0800, Jeremiah Mahler wrote:
> > I wasn't able to reproduce the sparse warning. Was it for a specific
> > architecture? Perhaps include a link to the email sent by the kbuild
> > test robot.
>
> You need to add a "CF=-D__CHECK_ENDIAN__" to turn these on.
>
> make C=2 CF=-D__CHECK_ENDIAN__
>
> http://lwn.net/Articles/205624/
>
> regards,
> dan carpenter
>
Even with __CHECK_ENDIAN__ I wasn't able to reproduce these errors
straight away because this fix is already in next. But once reverted
they appeared and the patch does fix all of them.
jeri@hudson:~/linux-next$ git checkout 2be7256fe7f
jeri@hudson:~/linux-next$ git reset --hard HEAD~1
jeri@hudson:~/linux-next$ make C=1 "CF=-D__CHECK_ENDIAN__"
(errors ...)
--
- Jeremiah Mahler
next prev parent reply other threads:[~2015-01-23 9:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 6:50 [PATCH 1/2] input: cyapa: fix sparse warning issue of incorrect type in assiggment Dudley Du
2015-01-22 6:50 ` [PATCH 2/2] input: cyapa: fix variable dereferenced before check 'gen5_pip->resp_len' issue Dudley Du
2015-01-22 16:22 ` Dmitry Torokhov
2015-01-22 9:31 ` [PATCH 1/2] input: cyapa: fix sparse warning issue of incorrect type in assiggment Jeremiah Mahler
2015-01-22 9:54 ` Dan Carpenter
2015-01-22 9:58 ` Dudley Du
2015-01-23 9:50 ` Jeremiah Mahler [this message]
2015-01-22 9:57 ` Dudley Du
2015-01-23 9:56 ` Jeremiah Mahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123095026.GA9314@hudson.localdomain \
--to=jmmahler@gmail.com \
--cc=bleung@google.com \
--cc=dan.carpenter@oracle.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dudl@cypress.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).