From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremiah Mahler Subject: Re: [PATCH 1/2] input: cyapa: fix sparse warning issue of incorrect type in assiggment Date: Fri, 23 Jan 2015 01:50:26 -0800 Message-ID: <20150123095026.GA9314@hudson.localdomain> References: <1421909406-1240-1-git-send-email-dudl@cypress.com> <20150122093129.GA7133@hudson.localdomain> <20150122095453.GL6507@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pd0-f174.google.com ([209.85.192.174]:62773 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271AbbAWJua (ORCPT ); Fri, 23 Jan 2015 04:50:30 -0500 Content-Disposition: inline In-Reply-To: <20150122095453.GL6507@mwanda> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dan Carpenter Cc: Dudley Du , dmitry.torokhov@gmail.com, rydberg@euromail.se, bleung@google.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Thu, Jan 22, 2015 at 12:54:53PM +0300, Dan Carpenter wrote: > On Thu, Jan 22, 2015 at 01:31:29AM -0800, Jeremiah Mahler wrote: > > I wasn't able to reproduce the sparse warning. Was it for a specific > > architecture? Perhaps include a link to the email sent by the kbuild > > test robot. > > You need to add a "CF=-D__CHECK_ENDIAN__" to turn these on. > > make C=2 CF=-D__CHECK_ENDIAN__ > > http://lwn.net/Articles/205624/ > > regards, > dan carpenter > Even with __CHECK_ENDIAN__ I wasn't able to reproduce these errors straight away because this fix is already in next. But once reverted they appeared and the patch does fix all of them. jeri@hudson:~/linux-next$ git checkout 2be7256fe7f jeri@hudson:~/linux-next$ git reset --hard HEAD~1 jeri@hudson:~/linux-next$ make C=1 "CF=-D__CHECK_ENDIAN__" (errors ...) -- - Jeremiah Mahler