From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] input: (gtco) use sign_extend32() for sign extension Date: Fri, 23 Jan 2015 16:47:24 -0800 Message-ID: <20150124004724.GA16356@dtor-ws> References: <1422016176-6299-1-git-send-email-martink@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1422016176-6299-1-git-send-email-martink@posteo.de> Sender: linux-kernel-owner@vger.kernel.org To: Martin Kepplinger Cc: khoroshilov@ispras.ru, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org On Fri, Jan 23, 2015 at 01:29:36PM +0100, Martin Kepplinger wrote: > Signed-off-by: Martin Kepplinger > --- > Despite it's name, sign_extend32() is safe to use for 8 and 16 bit types too. Applied, thank you, but I am sure it can be cleaned up even more. > > > drivers/input/tablet/gtco.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c > index 8580456..272a838 100644 > --- a/drivers/input/tablet/gtco.c > +++ b/drivers/input/tablet/gtco.c > @@ -59,7 +59,7 @@ Scott Hill shill@gtcocalcomp.com > #include > #include > #include > - > +#include > > #include > > @@ -666,13 +666,8 @@ static void gtco_urb_callback(struct urb *urbinfo) > case 4: > /* Tilt */ > > - /* Sign extend these 7 bit numbers. */ > - if (device->buffer[6] & 0x40) > - device->buffer[6] |= 0x80; > - > - if (device->buffer[7] & 0x40) > - device->buffer[7] |= 0x80; > - > + device->buffer[6] = sign_extend32(device->buffer[6], 6); > + device->buffer[7] = sign_extend32(device->buffer[7], 6); > > valsigned = (device->buffer[6]); > input_report_abs(inputdev, ABS_TILT_X, (s32)valsigned); > -- > 2.1.4 > -- Dmitry