Re: input: elantech.c: adding more Fujtisu notebooks to force crc_enabled

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Tue, Jan 27, 2015 at 09:20:57AM +0100, Rainer Koenig wrote:
> Extending the patch from November 2014 with two more Fujitsu LIFEBOOK
> models that also ship the Elantech touchpad and don't work with
> crc_disabled.
> 
> Signed-off-by: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>

Applied, thank you.

However I am not happy with the direction we are going - the fact that
we need to add more and more laptops to the quirk.  It would be better
if we could detect whether we need CRC or not by querying the touchpad
somehow. Elantech folks, could you help us here?

Thanks!

> 
> ---
> My responsibility is enabling Linux on Fujitsu desktops and sometimes
> also notebooks. Stumbled into this issue during investigation of a
> customer project and successfully tested the patch on both machines.
> 
> diff -uNr old/drivers/input/mouse/elantech.c new/drivers/input/mouse/elantech.c
> --- old/drivers/input/mouse/elantech.c	2015-01-27 08:51:18.101122218 +0100
> +++ new/drivers/input/mouse/elantech.c	2015-01-27 08:51:00.880921663 +0100
> @@ -1475,6 +1475,20 @@
>  			DMI_MATCH(DMI_PRODUCT_NAME, "CELSIUS H730"),
>  		},
>  	},
> +	{
> +		/* Fujitsu LIFEBOOK E554  does not work with crc_enabled == 0 */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E554"),
> +		},
> +	},
> +	{
> +		/* Fujitsu LIFEBOOK E544  does not work with crc_enabled == 0 */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E544"),
> +		},
> +	},
>  #endif
>  	{ }
>  };
> 
> -- 
> Dipl.-Inf. (FH) Rainer Koenig
> Project Manager Linux Clients
> Dept. PDG WPS R&D SW OSE
> 
> Fujitsu Technology Solutions
> Bürgermeister-Ullrich-Str. 100
> 86199 Augsburg
> Germany
> 
> Telephone: +49-821-804-3321
> Telefax:   +49-821-804-2131
> Mail:      mailto:Rainer.Koenig@ts.fujitsu.com
> 
> Internet         ts.fujtsu.com
> Company Details  ts.fujitsu.com/imprint.html

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html