linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Peter Hutterer <peter.hutterer@redhat.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH] input.h: Add BTN_SIDE2 button code
Date: Fri, 30 Jan 2015 14:35:37 -0800	[thread overview]
Message-ID: <20150130223537.GB23203@dtor-ws> (raw)
In-Reply-To: <1422008690-920-1-git-send-email-hdegoede@redhat.com>

Hi Hans,

On Fri, Jan 23, 2015 at 11:24:50AM +0100, Hans de Goede wrote:
> Some mice report buttons with a MSC_SCAN of 589833 this maps to a button code
> of 0x118, add a BTN_SIDE2 define for this to input.h
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1184352
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Looking at Logitech website it seems that one of teh buttons is marked
"zoom", so why don't we use KEY_ZOOM for it?

> ---
>  include/uapi/linux/input.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> index a1d7e93..27b0f6a 100644
> --- a/include/uapi/linux/input.h
> +++ b/include/uapi/linux/input.h
> @@ -498,6 +498,7 @@ struct input_keymap_entry {
>  #define BTN_FORWARD		0x115
>  #define BTN_BACK		0x116
>  #define BTN_TASK		0x117
> +#define BTN_SIDE2		0x118
>  
>  #define BTN_JOYSTICK		0x120
>  #define BTN_TRIGGER		0x120
> -- 
> 2.1.0
> 

Thanks.

-- 
Dmitry

  reply	other threads:[~2015-01-30 22:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 10:24 [PATCH] input.h: Add BTN_SIDE2 button code Hans de Goede
2015-01-30 22:35 ` Dmitry Torokhov [this message]
2015-02-03  8:13   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150130223537.GB23203@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=peter.hutterer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).