From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Dan Murphy <dmurphy@ti.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH 2/2] Input: drv2667 - Remove wrong and unneeded drv2667-haptics modalias
Date: Sat, 31 Jan 2015 20:21:22 -0800 [thread overview]
Message-ID: <20150201042122.GA24292@dtor-ws> (raw)
In-Reply-To: <1422681705.10152.2.camel@phoenix>
On Sat, Jan 31, 2015 at 01:21:45PM +0800, Axel Lin wrote:
> This is a I2C driver, so it's wrong to use platform prefix for the modalias.
> We have all needed i2c aliases coming form MODULE_DEVICE_TABLE,
> so remove the wrong and unneeded drv2667-haptics modalias.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Applied both, thank you.
> ---
> drivers/input/misc/drv2667.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/drv2667.c b/drivers/input/misc/drv2667.c
> index a021744..fc0fddf 100644
> --- a/drivers/input/misc/drv2667.c
> +++ b/drivers/input/misc/drv2667.c
> @@ -492,7 +492,6 @@ static struct i2c_driver drv2667_driver = {
> };
> module_i2c_driver(drv2667_driver);
>
> -MODULE_ALIAS("platform:drv2667-haptics");
> MODULE_DESCRIPTION("TI DRV2667 haptics driver");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Dan Murphy <dmurphy@ti.com>");
> --
> 1.9.1
>
>
>
--
Dmitry
prev parent reply other threads:[~2015-02-01 4:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 5:20 [PATCH 1/2] Input: drv260x - Remove wrong and unneeded drv260x-haptics modalias Axel Lin
2015-01-31 5:21 ` [PATCH 2/2] Input: drv2667 - Remove wrong and unneeded drv2667-haptics modalias Axel Lin
2015-02-01 4:21 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150201042122.GA24292@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=axel.lin@ingics.com \
--cc=dmurphy@ti.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).