linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Sebastien Bourdeauducq <sb@m-labs.hk>
Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>,
	linux-input <linux-input@vger.kernel.org>
Subject: Re: "i2c_hid: Could not register for interrupt, irq = -1" on Thinkpad Tablet 10
Date: Mon, 2 Feb 2015 15:48:05 +0200	[thread overview]
Message-ID: <20150202134805.GT22740@lahna.fi.intel.com> (raw)
In-Reply-To: <54CF7977.1090105@m-labs.hk>

On Mon, Feb 02, 2015 at 09:19:51PM +0800, Sebastien Bourdeauducq wrote:
> On Monday, February 02, 2015 06:00 PM, Mika Westerberg wrote:
> >>With this patch and IRQF_TRIGGER_LOW | IRQF_ONESHOT, I get an interrupt
> >>flood and the kernel disables the interrupt line. I have reverted it to
> >>IRQF_TRIGGER_FALLING | IRQF_ONESHOT, and the i2c_hid initialization
> >>completes successfully.
> >
> >That shouldn't happen :-(
> 
> With this computer nothing is normal. Every single component except the CPU,
> display and USB has major issues under Linux.

We need to get one here then. Can you point me to the exact model?

> >On all the panels I've tried, with or without GPIO, turning the
> >interrupt to active low works. How about Windows, have you tried if it
> >works there?
> 
> Yes, the Wacom digitizer works fine under Windows.
> 
> >Can you send output of /sys/kernel/debug/gpio when after the kernel has
> >disabled the interrupt?
> 
> Attached. The kernel message I get is "byt_gpio INT33FC:00: Gpio 56
> interrupt flood, disabling".
> 
> I also get a "byt_gpio INT33FC:02: Gpio 18 interrupt flood, disabling"
> before which seems unrelated.

>  gpio-56  (?                   ) in     lo pad-79  offset:0x4f0 mux:0                  up   20k

This explains, it is low all the time.

Since it has 20k internal pull-up configured, I'm guessing something
(the digitizer) drives it low like it still has something to report. Do
you see in the dmesg if the i2c-hid.c is able to read reports from the
device?

  reply	other threads:[~2015-02-02 13:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-31 15:01 "i2c_hid: Could not register for interrupt, irq = -1" on Thinkpad Tablet 10 Sebastien Bourdeauducq
2015-01-31 20:39 ` Benjamin Tissoires
2015-02-01  3:27   ` Sebastien Bourdeauducq
2015-02-02 10:00     ` Mika Westerberg
2015-02-02 13:19       ` Sebastien Bourdeauducq
2015-02-02 13:48         ` Mika Westerberg [this message]
2015-02-02 15:32           ` Sébastien Bourdeauducq
2015-02-02 15:42             ` Benjamin Tissoires
2015-02-02 15:55               ` Sébastien Bourdeauducq
2015-02-02 15:57             ` Mika Westerberg
2015-02-03  8:53               ` Sébastien Bourdeauducq
2015-02-03 11:25                 ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150202134805.GT22740@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=benjamin.tissoires@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=sb@m-labs.hk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).