From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v6 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Date: Tue, 3 Feb 2015 11:49:56 -0800 Message-ID: <20150203194956.GD20256@dtor-ws> References: <1420609779-11156-1-git-send-email-vigneshr@ti.com> <1420609779-11156-3-git-send-email-vigneshr@ti.com> <54CB1604.9030709@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <54CB1604.9030709-l0cyMroinI0@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vignesh R Cc: Jonathan Cameron , Hartmut Knaack , Lee Jones , Sebastian Andrzej Siewior , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Benoit Cousson , Tony Lindgren , Russell King , Lars-Peter Clausen , Peter Meerwald , Samuel Ortiz , Brad Griffis , Paul Gortmaker , Sanjeev Sharma , Jan Kardell , Felipe Balbi , Wolfram Sang , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-input@vger.kernel.org On Fri, Jan 30, 2015 at 10:56:28AM +0530, Vignesh R wrote: > > > On Wednesday 07 January 2015 11:19 AM, Vignesh R wrote: > > From: Brad Griffis > > > > TSC interrupt handler had udelay to avoid reporting of false pen-up > > interrupt to user space. This patch implements workaround suggesting in > > Advisory 1.0.31 of silicon errata for am335x, thus eliminating udelay > > and touchscreen lag. This also improves performance of touchscreen and > > eliminates sudden jump of cursor at touch release. > > > > IDLECONFIG and CHARGECONFIG registers are to be configured > > with same values in order to eliminate false pen-up events. This > > workaround may result in false pen-down to be detected, hence considerable > > charge step delay needs to be added. The charge delay is set to 0xB000 > > (in terms of ADC clock cycles) by default. > > > > TSC steps are disabled at the end of every sampling cycle and EOS bit is > > set. Once the EOS bit is set, the TSC steps need to be re-enabled to begin > > next sampling cycle. > > > > Signed-off-by: Brad Griffis > > [vigneshr-l0cyMroinI0@public.gmane.org: Ported the patch from v3.12 to v3.19rc1] > > > > Signed-off-by: Vignesh R > > --- > > Ping... Can somebody pick this patch series if there are no more comments?? Yes, I picked up everything but patch #3 as I assume Lee will merge it through MFD tree. Thanks. -- Dmitry