linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sonic Zhang <sonic.adi@gmail.com>
Cc: Steven Miao <realmz6@gmail.com>,
	adi-buildroot-devel@lists.sourceforge.net,
	linux-input@vger.kernel.org, Sonic Zhang <sonic.zhang@analog.com>
Subject: Re: [PATCH] blackfin: convert pinmux request API into empty static inline functions for bf609 and bf548
Date: Fri, 6 Feb 2015 15:30:50 -0800	[thread overview]
Message-ID: <20150206233050.GD29225@dtor-ws> (raw)
In-Reply-To: <1423215699-11153-1-git-send-email-sonic.adi@gmail.com>

On Fri, Feb 06, 2015 at 05:41:39PM +0800, Sonic Zhang wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
> 
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

I do not think arch changes shoudl go through my tree though...

> ---
>  arch/blackfin/include/asm/portmux.h |   15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/blackfin/include/asm/portmux.h b/arch/blackfin/include/asm/portmux.h
> index ccb96ca..2f6893e 100644
> --- a/arch/blackfin/include/asm/portmux.h
> +++ b/arch/blackfin/include/asm/portmux.h
> @@ -23,10 +23,17 @@ int bfin_internal_set_wake(unsigned int irq, unsigned int state);
>  #define gpio_pint_regs bfin_pint_regs
>  #define adi_internal_set_wake bfin_internal_set_wake
>  
> -#define peripheral_request(per, label) (0)
> -#define peripheral_free(per)
> -#define peripheral_request_list(per, label) (0)
> -#define peripheral_free_list(per)
> +static inline int peripheral_request(unsigned short per, const char *label)
> +{
> +	return 0;
> +}
> +static inline void peripheral_free(unsigned short per) {}
> +static inline int peripheral_request_list(const unsigned short per[],
> +					  const char *label)
> +{
> +	return 0;
> +}
> +static inline void peripheral_free_list(const unsigned short per[]) {}
>  int pinmux_request(unsigned short per, const char *label);
>  void pinmux_free(unsigned short per);
>  int pinmux_request_list(const unsigned short per[], const char *label);
> -- 
> 1.7.9.5
> 

-- 
Dmitry

      reply	other threads:[~2015-02-06 23:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-06  9:41 [PATCH] blackfin: convert pinmux request API into empty static inline functions for bf609 and bf548 Sonic Zhang
2015-02-06 23:30 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150206233050.GD29225@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=adi-buildroot-devel@lists.sourceforge.net \
    --cc=linux-input@vger.kernel.org \
    --cc=realmz6@gmail.com \
    --cc=sonic.adi@gmail.com \
    --cc=sonic.zhang@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).