From: Johan Hovold <johan@kernel.org>
To: Sylvain Rochet <sylvain.rochet@finsecur.com>
Cc: linux-input@vger.kernel.org, Daniel Mack <daniel@caiaq.de>,
Johan Hovold <jhovold@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCHv2] input: rotary encoder: Add wake up support
Date: Sun, 8 Feb 2015 12:07:16 +0800 [thread overview]
Message-ID: <20150208040716.GA544@localhost> (raw)
In-Reply-To: <1422529818-6140-2-git-send-email-sylvain.rochet@finsecur.com>
On Thu, Jan 29, 2015 at 12:10:18PM +0100, Sylvain Rochet wrote:
> This patch add wake up support for rotary encoders.
>
> Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
> @@ -306,6 +311,8 @@ static int rotary_encoder_remove(struct platform_device *pdev)
> struct rotary_encoder *encoder = platform_get_drvdata(pdev);
> const struct rotary_encoder_platform_data *pdata = encoder->pdata;
>
> + device_init_wakeup(&pdev->dev, 0);
> +
Perhaps you should use false rather than 0 here for consistency.
Looks good otherwise, so feel free to add my
Reviewed-by: Johan Hovold <johan@kernel.org>
If you resend, you could split the device-tree binding documentation in
a separate patch that you CC the devicetree list in order to get an ack
for the property name.
Johan
next prev parent reply other threads:[~2015-02-08 4:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 11:10 [PATCHv2] input: rotary encoder: Add wake up support Sylvain Rochet
2015-01-29 11:10 ` Sylvain Rochet
2015-02-08 4:07 ` Johan Hovold [this message]
2015-02-12 15:42 ` Sylvain Rochet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150208040716.GA544@localhost \
--to=johan@kernel.org \
--cc=daniel@caiaq.de \
--cc=dmitry.torokhov@gmail.com \
--cc=jhovold@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=sylvain.rochet@finsecur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).