From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andrew Rodland <andrew@cleverdomain.org>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: Mayflash / Dragonrise GameCube controller adapter recognized as tablet, not joystick
Date: Wed, 11 Feb 2015 10:17:24 -0800 [thread overview]
Message-ID: <20150211181724.GD29440@dtor-ws> (raw)
In-Reply-To: <CABFQKmMMJBj==983B-hgxT5MqpYV7uesSLvQqKgsTMXHgL+rMg@mail.gmail.com>
Hi Andrew,
On Thu, Feb 05, 2015 at 12:02:21AM -0500, Andrew Rodland wrote:
> On Wed, Feb 4, 2015 at 7:48 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > Hi Andrew,
> >
> >
> > From the list of events you posted below it seems the device needs
> > HID_QUIRK_MULTI_INPUT to split it into 4 individual input devices.
> >
> That did the trick neatly. Everything works, although no force
> feedback (and sadly hacking it into hid-dr isn't as trivial as I
> hoped).
>
> Patch in case it's useful (attached because of gmail, sorry).
>
> (which also doesn't reply to list by default, so here's a dupe. Some
> day I'll switch back to a real mail client.)
Thank you for the patch. For it to be applied you need to add your
"Signed-off-by" to the commit message - see
Documentation/SubmittingPatches - and explain in the commit message why
the change was needed.
Please also CC Jiri Kosina <jkosina@suse.cz> on your next submission
since he's the maintainer of HID subsystem and the patch will need to go
through his tree.
Thanks!
> From 61ca320a43f652edeb00d37fecfef1f2226afbab Mon Sep 17 00:00:00 2001
> From: Andrew Rodland <andrew@cleverdomain.org>
> Date: Wed, 4 Feb 2015 23:09:36 -0500
> Subject: [PATCH] Add HID_QUIRK_MULTI_INPUT for Dragonrise GameCube adapter
>
> ---
> drivers/hid/hid-ids.h | 3 ++-
> drivers/hid/usbhid/hid-quirks.c | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 9243359..041753e 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -272,7 +272,8 @@
> #define USB_VENDOR_ID_DMI 0x0c0b
> #define USB_DEVICE_ID_DMI_ENC 0x5fab
>
> -#define USB_VENDOR_ID_DRAGONRISE 0x0079
> +#define USB_VENDOR_ID_DRAGONRISE 0x0079
> +#define USB_DEVICE_ID_DRAGONRISE_GAMECUBE 0x1843
>
> #define USB_VENDOR_ID_DWAV 0x0eef
> #define USB_DEVICE_ID_EGALAX_TOUCHCONTROLLER 0x0001
> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> index b27b3d3..e47a445 100644
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -70,6 +70,7 @@ static const struct hid_blacklist {
> { USB_VENDOR_ID_CH, USB_DEVICE_ID_CH_3AXIS_5BUTTON_STICK, HID_QUIRK_NOGET },
> { USB_VENDOR_ID_CH, USB_DEVICE_ID_CH_AXIS_295, HID_QUIRK_NOGET },
> { USB_VENDOR_ID_DMI, USB_DEVICE_ID_DMI_ENC, HID_QUIRK_NOGET },
> + { USB_VENDOR_ID_DRAGONRISE, USB_DEVICE_ID_DRAGONRISE_GAMECUBE, HID_QUIRK_MULTI_INPUT },
> { USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ELAN_TOUCHSCREEN, HID_QUIRK_ALWAYS_POLL },
> { USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ELAN_TOUCHSCREEN_009B, HID_QUIRK_ALWAYS_POLL },
> { USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ELAN_TOUCHSCREEN_0103, HID_QUIRK_ALWAYS_POLL },
> --
> 1.9.1
>
--
Dmitry
prev parent reply other threads:[~2015-02-11 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 0:34 Mayflash / Dragonrise GameCube controller adapter recognized as tablet, not joystick Andrew Rodland
2015-02-05 0:48 ` Dmitry Torokhov
2015-02-05 5:02 ` Andrew Rodland
2015-02-11 18:17 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150211181724.GD29440@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andrew@cleverdomain.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).