Re: [PATCH v3 2/2] input: rotary encoder: Add wake up support

[Johan Hovold <johan@kernel.org>]

On Fri, Feb 13, 2015 at 10:12:08AM +0100, Sylvain Rochet wrote:
> Hello Johan,
> 
> On Fri, Feb 13, 2015 at 11:43:17AM +0800, Johan Hovold wrote:
> > On Thu, Feb 12, 2015 at 04:40:38PM +0100, Sylvain Rochet wrote:
> > > This patch adds wake up support for rotary encoders.
> > > 
> > > Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
> > > Reviewed-by: Johan Hovold <johan@kernel.org>
> > > ---
> > >  Documentation/input/rotary-encoder.txt |  1 +
> > >  drivers/input/misc/rotary_encoder.c    | 37 ++++++++++++++++++++++++++++++++++
> > >  include/linux/rotary_encoder.h         |  1 +
> > >  3 files changed, 39 insertions(+)
> > > 
> > > diff --git a/Documentation/input/rotary-encoder.txt b/Documentation/input/rotary-encoder.txt
> > > index 92e68bc..ed158d3 100644
> > > --- a/Documentation/input/rotary-encoder.txt
> > > +++ b/Documentation/input/rotary-encoder.txt
> > > @@ -109,6 +109,7 @@ static struct rotary_encoder_platform_data my_rotary_encoder_info = {
> > >  	.inverted_a	= 0,
> > >  	.inverted_b	= 0,
> > >  	.half_period	= false,
> > > +	.wakeup_source	= false,
> > >  };
> > 
> > This should have been part of PATCH 1/2 as well.
> 
> Oops, this is not what I understand :(, should I resend ?

You can wait and see what the device-tree folks says about using
"wakeup-source" as property name first.

Johan