From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mathias Gottschlag <mgottschlag@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH 2/3] psmouse: Skip psmouse_initialize for FocalTech touchpads.
Date: Wed, 18 Feb 2015 11:55:37 -0800 [thread overview]
Message-ID: <20150218195537.GA13997@dtor-glaptop> (raw)
In-Reply-To: <1423940502-12353-3-git-send-email-mgottschlag@gmail.com>
Hi Mathias,
On Sat, Feb 14, 2015 at 08:01:41PM +0100, Mathias Gottschlag wrote:
> /*
> @@ -1157,7 +1159,7 @@ static void psmouse_initialize(struct psmouse *psmouse)
> * We set the mouse report rate, resolution and scaling.
> */
>
> - if (psmouse_max_proto != PSMOUSE_PS2) {
> + if (psmouse_max_proto != PSMOUSE_PS2 && !psmouse->skip_standard_init) {
> psmouse->set_rate(psmouse, psmouse->rate);
> psmouse->set_resolution(psmouse, psmouse->resolution);
> ps2_command(&psmouse->ps2dev, NULL, PSMOUSE_CMD_SETSCALE11);
Instead of introducing the new skip_standard_init flag can you instead define a
pointer for set_scale implementation and provide a dummy stub for it in
focatech, the same as you do for set_rate() and set_resoluton() in patch 3?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-02-18 19:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-14 19:01 [PATCH 0/3] Fix a regression in the FocalTech touchpad driver Mathias Gottschlag
2015-02-14 19:01 ` [PATCH 1/3] psmouse: Remove hardcoded touchpad size from the focaltech driver Mathias Gottschlag
2015-02-18 19:57 ` Dmitry Torokhov
2015-02-14 19:01 ` [PATCH 2/3] psmouse: Skip psmouse_initialize for FocalTech touchpads Mathias Gottschlag
2015-02-18 19:55 ` Dmitry Torokhov [this message]
2015-02-14 19:01 ` [PATCH 3/3] psmouse: Disable resolution/rate changes " Mathias Gottschlag
2015-02-26 23:20 ` [PATCHv2 0/4] FocalTech touchpad fixes Mathias Gottschlag
2015-02-26 23:20 ` [PATCHv2 1/4] psmouse: Remove hardcoded touchpad size from the focaltech driver Mathias Gottschlag
2015-02-26 23:20 ` [PATCHv2 2/4] psmouse: Ensure that the focaltech driver reports consistent coordinates Mathias Gottschlag
2015-02-26 23:20 ` [PATCHv2 3/4] psmouse: Disable resolution/rate/scale changes for FocalTech touchpads Mathias Gottschlag
2015-03-08 4:14 ` Dmitry Torokhov
2015-02-26 23:20 ` [PATCHv2 4/4] psmouse: Disable "palm detection" in the focaltech driver Mathias Gottschlag
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150218195537.GA13997@dtor-glaptop \
--to=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=mgottschlag@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).