From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: "Lothar Waßmann" <LW@KARO-electronics.de>,
linux-input@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] input: edt-ft5x06, Add i2c device ids
Date: Fri, 20 Feb 2015 10:32:50 -0800 [thread overview]
Message-ID: <20150220183250.GA20060@dtor-glaptop> (raw)
In-Reply-To: <1424447785-14337-1-git-send-email-mpa@pengutronix.de>
Hi Markus,
On Fri, Feb 20, 2015 at 04:56:25PM +0100, Markus Pargmann wrote:
> These ids are necessary to use edt-ft5x06 as a kernel module. Otherwise
> it is not loaded automatically in userspace because the ids do not match.
>
We already have all module aliases needed, please fix i2c to generate modalias
for devices described in OF properly.
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> drivers/input/touchscreen/edt-ft5x06.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> index d4c24fb7704f..63ad6d545bbe 100644
> --- a/drivers/input/touchscreen/edt-ft5x06.c
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
> @@ -1119,6 +1119,9 @@ static SIMPLE_DEV_PM_OPS(edt_ft5x06_ts_pm_ops,
>
> static const struct i2c_device_id edt_ft5x06_ts_id[] = {
> { "edt-ft5x06", 0, },
> + { "edt-ft5206", 0, },
> + { "edt-ft5306", 0, },
> + { "edt-ft5406", 0, },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(i2c, edt_ft5x06_ts_id);
> --
> 2.1.4
>
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-02-20 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 15:56 [PATCH] input: edt-ft5x06, Add i2c device ids Markus Pargmann
2015-02-20 18:32 ` Dmitry Torokhov [this message]
2015-02-23 22:06 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220183250.GA20060@dtor-glaptop \
--to=dmitry.torokhov@gmail.com \
--cc=LW@KARO-electronics.de \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=mpa@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).