linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
	Mark Rutland <mark.rutland@arm.com>,
	sb@m-labs.hk, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] HID: wacom: Add support for I2C connected devices
Date: Mon, 23 Feb 2015 10:22:17 -0500	[thread overview]
Message-ID: <20150223152216.GD27578@mail.corp.redhat.com> (raw)
In-Reply-To: <1424699565-138045-2-git-send-email-mika.westerberg@linux.intel.com>

On Feb 23 2015 or thereabouts, Mika Westerberg wrote:
> Lenovo Thinkpad 10 has wacom digitizer connected as a I2C-HID device. Add
> generic support for this.
> 
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---

This one is
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

And can be applied right now I guess.

Cheers,
Benjamin

>  drivers/hid/wacom_wac.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
> index 1a6507999a65..c8e73bf62468 100644
> --- a/drivers/hid/wacom_wac.c
> +++ b/drivers/hid/wacom_wac.c
> @@ -2969,6 +2969,10 @@ static const struct wacom_features wacom_features_HID_ANY_ID =
>  	HID_DEVICE(BUS_BLUETOOTH, HID_GROUP_WACOM, USB_VENDOR_ID_WACOM, prod),\
>  	.driver_data = (kernel_ulong_t)&wacom_features_##prod
>  
> +#define I2C_DEVICE_WACOM(prod)						\
> +	HID_DEVICE(BUS_I2C, HID_GROUP_WACOM, USB_VENDOR_ID_WACOM, prod),\
> +	.driver_data = (kernel_ulong_t)&wacom_features_##prod
> +
>  #define USB_DEVICE_LENOVO(prod)					\
>  	HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, prod),			\
>  	.driver_data = (kernel_ulong_t)&wacom_features_##prod
> @@ -3113,6 +3117,7 @@ const struct hid_device_id wacom_ids[] = {
>  	{ USB_DEVICE_LENOVO(0x6004) },
>  
>  	{ USB_DEVICE_WACOM(HID_ANY_ID) },
> +	{ I2C_DEVICE_WACOM(HID_ANY_ID) },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(hid, wacom_ids);
> -- 
> 2.1.4
> 

  reply	other threads:[~2015-02-23 15:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 13:52 [PATCH 0/3] HID: Support for Lenovo Thinkpad 10 digitizer Mika Westerberg
2015-02-23 13:52 ` [PATCH 1/3] HID: wacom: Add support for I2C connected devices Mika Westerberg
2015-02-23 15:22   ` Benjamin Tissoires [this message]
2015-02-24 10:31   ` Jiri Kosina
2015-02-23 13:52 ` [PATCH 2/3] HID: i2c-hid: Read wMaxInputLength of input report instead of bufsize Mika Westerberg
2015-02-23 15:26   ` Benjamin Tissoires
2015-02-24  7:05     ` Mika Westerberg
2015-02-23 13:52 ` [PATCH 3/3] HID: i2c-hid: Add support for ACPI GPIO interrupts Mika Westerberg
2015-02-23 15:35   ` Benjamin Tissoires
2015-02-24  7:42     ` Mika Westerberg
2015-02-24 20:02   ` Jiri Kosina
2015-02-24 21:27   ` Antonio Ospite
2015-02-25  8:02     ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150223152216.GD27578@mail.corp.redhat.com \
    --to=benjamin.tissoires@redhat.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=sb@m-labs.hk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).