From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: Bug in i2c-core? Date: Fri, 27 Feb 2015 19:39:49 +0100 Message-ID: <20150227183949.GT7789@pengutronix.de> References: <54F0507F.6030804@armadeus.com> <20150227153725.7404dea1@free-electrons.com> <6C8798CF-7222-465B-9354-93500B584B4D@gmail.com> <20150227170545.GS7789@pengutronix.de> <20150227174611.GC6679@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:40381 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752069AbbB0Sjx (ORCPT ); Fri, 27 Feb 2015 13:39:53 -0500 Content-Disposition: inline In-Reply-To: <20150227174611.GC6679@dtor-ws> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Thomas Petazzoni , =?iso-8859-1?Q?S=E9bastien?= SZYMANSKI , "linux-arm-kernel@lists.infradead.org" , Wolfram Sang , laurent.pinchart+renesas@ideasonboard.com, linux-input@vger.kernel.org, linux-i2c@vger.kernel.org Hello, On Fri, Feb 27, 2015 at 09:46:11AM -0800, Dmitry Torokhov wrote: > On Fri, Feb 27, 2015 at 06:05:45PM +0100, Uwe Kleine-K=F6nig wrote: > > On Fri, Feb 27, 2015 at 07:29:30AM -0800, Dmitry Torokhov wrote: > > > On February 27, 2015 6:37:25 AM PST, Thomas Petazzoni wrote: > > > >Dear S=E9bastien SZYMANSKI, > > > > > > > >On Fri, 27 Feb 2015 12:09:51 +0100, S=E9bastien SZYMANSKI wrote: > > > > > > > >> error =3D input_register_device(sx8654->input); > > > >> if (error) > > > >> return error; > > > > > > > >Where is your ->remove() function that unregisters the input dev= ice? > > >=20 > > > Everything seems to be allocated with devm so remove is not neede= d. > > Everything is devm_* but input_register_device, right? >=20 > Input is allocated with devm_* and input_register_device knows how to > deal with that: ah, something new each day. Thanks for teaching me. Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= | -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html