From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dudley Du <dudl@cypress.com>
Cc: jmmahler@gmail.com, rydberg@euromail.se, bleung@google.com,
kbuild-all@01.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: cyapa: fix unaligned functions redefinition error
Date: Mon, 2 Mar 2015 09:38:51 -0800 [thread overview]
Message-ID: <20150302173851.GC17094@dtor-ws> (raw)
In-Reply-To: <1425276278-12298-1-git-send-email-dudl@cypress.com>
On Mon, Mar 02, 2015 at 02:04:38PM +0800, Dudley Du wrote:
> Use asm/unaligned.h instead of linux/unaligned/access_ok.h head file to
> fix compiling issues such as following while doing cross platform compiling.
> "include/linux/unaligned/access_ok.h:7:19: error: redefinition of
> 'get_unaligned_le16'
> ...
> include/linux/unaligned/le_struct.h:6:19: note: previous definition of
> 'get_unaligned_le16' was here".
>
> Reported-by: kbuild test robot <kbuild-all@01.org>
> Signed-off-by: Dudley Du <dudl@cypress.com>
Applied, thank you.
> ---
> drivers/input/mouse/cyapa_gen3.c | 2 +-
> drivers/input/mouse/cyapa_gen5.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/mouse/cyapa_gen3.c b/drivers/input/mouse/cyapa_gen3.c
> index 77e9d70..1e2291c 100644
> --- a/drivers/input/mouse/cyapa_gen3.c
> +++ b/drivers/input/mouse/cyapa_gen3.c
> @@ -20,7 +20,7 @@
> #include <linux/input/mt.h>
> #include <linux/module.h>
> #include <linux/slab.h>
> -#include <linux/unaligned/access_ok.h>
> +#include <asm/unaligned.h>
> #include "cyapa.h"
>
>
> diff --git a/drivers/input/mouse/cyapa_gen5.c b/drivers/input/mouse/cyapa_gen5.c
> index ddf5393..aa68edd 100644
> --- a/drivers/input/mouse/cyapa_gen5.c
> +++ b/drivers/input/mouse/cyapa_gen5.c
> @@ -17,7 +17,7 @@
> #include <linux/mutex.h>
> #include <linux/completion.h>
> #include <linux/slab.h>
> -#include <linux/unaligned/access_ok.h>
> +#include <asm/unaligned.h>
> #include <linux/crc-itu-t.h>
> #include "cyapa.h"
>
> --
> 1.9.1
>
--
Dmitry
prev parent reply other threads:[~2015-03-02 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 6:04 [PATCH] input: cyapa: fix unaligned functions redefinition error Dudley Du
2015-03-02 17:38 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302173851.GC17094@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=bleung@google.com \
--cc=dudl@cypress.com \
--cc=jmmahler@gmail.com \
--cc=kbuild-all@01.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).