From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aleksei Mamlin Subject: Re: [PATCH 2/2] input: goodix: Add device tree support for 5-finger chips Date: Wed, 4 Mar 2015 20:53:36 +0300 Message-ID: <20150304205336.e429e40d2a4610ed1b136814@gmail.com> References: <1425457930-4481-1-git-send-email-mamlinav@gmail.com> <1425458053-4559-1-git-send-email-mamlinav@gmail.com> <1425460748.9384.2.camel@hadess.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1425460748.9384.2.camel-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bastien Nocera Cc: linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Hans de Goede List-Id: linux-input@vger.kernel.org On Wed, 04 Mar 2015 10:19:08 +0100 Bastien Nocera wrote: > On Wed, 2015-03-04 at 11:34 +0300, Aleksei Mamlin wrote: > > This patch adds device tree support for 5-finger chips, like GT911 > > and GT912. > > You should add the same support to the ACPI matching. Hi Bastien, I never seen ACPI ids for GT911 or GT912. It seems they are used only on Andriod tablets. > > > > #ifdef CONFIG_OF > > static struct of_device_id goodix_of_match[] = { > > - { .compatible = "goodix,gt9110" }, > > - { .compatible = "goodix,gt927" }, > > - { .compatible = "goodix,gt9271" }, > > - { .compatible = "goodix,gt928" }, > > - { .compatible = "goodix,gt967" }, > > + { .compatible = "goodix,gt911", .data = (void *) 5 }, > > + { .compatible = "goodix,gt9110", .data = (void *) 10 }, > > There's no need to add "10" for these tablets as it's already the > GOODIX_MAX_CONTACTS value. Or you need to add it to every instance. Antonio Ospite showed me another way to set the max number of touch points. > > I would also like a link to the spec sheets in the commit message. > > > + { .compatible = "goodix,gt912", .data = (void *) 5 }, > > + { .compatible = "goodix,gt927", .data = (void *) 10 }, > > + { .compatible = "goodix,gt9271", .data = (void *) 10 }, > > + { .compatible = "goodix,gt928", .data = (void *) 10 }, > > + { .compatible = "goodix,gt967", .data = (void *) 10 }, > > { } > > }; > > MODULE_DEVICE_TABLE(of, goodix_of_match); -- Thanks and regards, Aleksei Mamlin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html