From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Stefan Brüns" <stefan.bruens@rwth-aachen.de>
Cc: linux-input@vger.kernel.org, Darren Hart <dvhart@infradead.org>,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH 2/2] use more descriptive KEY_ROTATE_DISPLAY instead of KEY_DIRECTION
Date: Thu, 5 Mar 2015 23:56:00 -0800 [thread overview]
Message-ID: <20150306075600.GB14237@dtor-ws> (raw)
In-Reply-To: <cf97f856-7e6d-4753-a3f0-51c410cc2db4@HUB2.rwth-ad.de>
On Thu, Mar 05, 2015 at 12:31:10AM +0100, Stefan Brüns wrote:
> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
This should go through HID and platform trees unless I hear otherwise.
> ---
> drivers/hid/hid-debug.c | 2 +-
> drivers/platform/x86/fujitsu-tablet.c | 6 +++---
> drivers/platform/x86/hp-wmi.c | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
> index 8bf61d2..1086800 100644
> --- a/drivers/hid/hid-debug.c
> +++ b/drivers/hid/hid-debug.c
> @@ -814,7 +814,7 @@ static const char *keys[KEY_MAX + 1] = {
> [KEY_DELETEFILE] = "DeleteFile", [KEY_XFER] = "X-fer",
> [KEY_PROG1] = "Prog1", [KEY_PROG2] = "Prog2",
> [KEY_WWW] = "WWW", [KEY_MSDOS] = "MSDOS",
> - [KEY_COFFEE] = "Coffee", [KEY_DIRECTION] = "Direction",
> + [KEY_COFFEE] = "Coffee", [KEY_ROTATE_DISPLAY] = "RotateDisplay",
> [KEY_CYCLEWINDOWS] = "CycleWindows", [KEY_MAIL] = "Mail",
> [KEY_BOOKMARKS] = "Bookmarks", [KEY_COMPUTER] = "Computer",
> [KEY_BACK] = "Back", [KEY_FORWARD] = "Forward",
> diff --git a/drivers/platform/x86/fujitsu-tablet.c b/drivers/platform/x86/fujitsu-tablet.c
> index 53bdbb0..baea077 100644
> --- a/drivers/platform/x86/fujitsu-tablet.c
> +++ b/drivers/platform/x86/fujitsu-tablet.c
> @@ -59,7 +59,7 @@ static unsigned short keymap_Lifebook_Tseries[KEYMAP_LEN] __initdata = {
> KEY_RESERVED,
> KEY_SCROLLDOWN,
> KEY_SCROLLUP,
> - KEY_DIRECTION,
> + KEY_ROTATE_DISPLAY,
> KEY_LEFTCTRL,
> KEY_BRIGHTNESSUP,
> KEY_BRIGHTNESSDOWN,
> @@ -116,7 +116,7 @@ static unsigned short keymap_Lifebook_U810[KEYMAP_LEN] __initdata = {
> KEY_RESERVED,
> KEY_PROG1,
> KEY_PROG2,
> - KEY_DIRECTION,
> + KEY_ROTATE_DISPLAY,
> KEY_RESERVED,
> KEY_RESERVED,
> KEY_RESERVED,
> @@ -153,7 +153,7 @@ static unsigned short keymap_Stylistic_ST5xxx[KEYMAP_LEN] __initdata = {
> KEY_RESERVED,
> KEY_RESERVED,
> KEY_MAIL,
> - KEY_DIRECTION,
> + KEY_ROTATE_DISPLAY,
> KEY_ESC,
> KEY_ENTER,
> KEY_BRIGHTNESSUP,
> diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
> index 0ab2b37..0669731 100644
> --- a/drivers/platform/x86/hp-wmi.c
> +++ b/drivers/platform/x86/hp-wmi.c
> @@ -144,7 +144,7 @@ static const struct key_entry hp_wmi_keymap[] = {
> { KE_KEY, 0x20e8, { KEY_MEDIA } },
> { KE_KEY, 0x2142, { KEY_MEDIA } },
> { KE_KEY, 0x213b, { KEY_INFO } },
> - { KE_KEY, 0x2169, { KEY_DIRECTION } },
> + { KE_KEY, 0x2169, { KEY_ROTATE_DISPLAY } },
> { KE_KEY, 0x216a, { KEY_SETUP } },
> { KE_KEY, 0x231b, { KEY_HELP } },
> { KE_END, 0 }
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-03-06 7:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 21:42 [PATCH] Add short KEY_DIRECTION description Stefan Brüns
2015-03-04 21:56 ` Bastien Nocera
2015-03-04 23:31 ` [PATCH 0/2] Replace KEY_DIRECTION with KEY_ROTATE_DISPLAY Stefan Brüns
[not found] ` <1425511870-3303-1-git-send-email-stefan.bruens@rwth-aachen.de>
2015-03-04 23:31 ` [PATCH v2 1/2] Add alias KEY_ROTATE_DISPLAY for KEY_DIRECTION, add description Stefan Brüns
2015-03-06 7:54 ` Dmitry Torokhov
2015-03-04 23:31 ` [PATCH 2/2] use more descriptive KEY_ROTATE_DISPLAY instead of KEY_DIRECTION Stefan Brüns
2015-03-06 7:56 ` Dmitry Torokhov [this message]
2015-03-06 18:15 ` Darren Hart
2015-03-06 21:45 ` Jiri Kosina
2015-03-07 0:34 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306075600.GB14237@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=dvhart@infradead.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=stefan.bruens@rwth-aachen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).