* [PATCH] Add short KEY_DIRECTION description @ 2015-03-04 21:42 Stefan Brüns 2015-03-04 21:56 ` Bastien Nocera 0 siblings, 1 reply; 10+ messages in thread From: Stefan Brüns @ 2015-03-04 21:42 UTC (permalink / raw) To: linux-input; +Cc: Stefan Brüns Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> --- Requested 5 years ago: https://lkml.org/lkml/2010/2/27/36 See also http://comments.gmane.org/gmane.linux.kernel.input/11175 include/uapi/linux/input.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index a1d7e93..0655300 100644 --- a/include/uapi/linux/input.h +++ b/include/uapi/linux/input.h @@ -368,7 +368,7 @@ struct input_keymap_entry { #define KEY_MSDOS 151 #define KEY_COFFEE 152 /* AL Terminal Lock/Screensaver */ #define KEY_SCREENLOCK KEY_COFFEE -#define KEY_DIRECTION 153 +#define KEY_DIRECTION 153 /* Display orientation for e.g. tablets */ #define KEY_CYCLEWINDOWS 154 #define KEY_MAIL 155 #define KEY_BOOKMARKS 156 /* AC Bookmarks */ -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] Add short KEY_DIRECTION description 2015-03-04 21:42 [PATCH] Add short KEY_DIRECTION description Stefan Brüns @ 2015-03-04 21:56 ` Bastien Nocera 2015-03-04 23:31 ` [PATCH 0/2] Replace KEY_DIRECTION with KEY_ROTATE_DISPLAY Stefan Brüns [not found] ` <1425511870-3303-1-git-send-email-stefan.bruens@rwth-aachen.de> 0 siblings, 2 replies; 10+ messages in thread From: Bastien Nocera @ 2015-03-04 21:56 UTC (permalink / raw) To: Stefan Brüns; +Cc: <linux-input@vger.kernel.org> I need the same key in my Thinkpad patch. But could you use a more descriptive name, such as KEY_ROTATE_DISPLAY? > On 4 Mar 2015, at 22:42, Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote: > > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> > --- > Requested 5 years ago: https://lkml.org/lkml/2010/2/27/36 > See also http://comments.gmane.org/gmane.linux.kernel.input/11175 > > include/uapi/linux/input.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h > index a1d7e93..0655300 100644 > --- a/include/uapi/linux/input.h > +++ b/include/uapi/linux/input.h > @@ -368,7 +368,7 @@ struct input_keymap_entry { > #define KEY_MSDOS 151 > #define KEY_COFFEE 152 /* AL Terminal Lock/Screensaver */ > #define KEY_SCREENLOCK KEY_COFFEE > -#define KEY_DIRECTION 153 > +#define KEY_DIRECTION 153 /* Display orientation for e.g. tablets */ > #define KEY_CYCLEWINDOWS 154 > #define KEY_MAIL 155 > #define KEY_BOOKMARKS 156 /* AC Bookmarks */ > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/2] Replace KEY_DIRECTION with KEY_ROTATE_DISPLAY 2015-03-04 21:56 ` Bastien Nocera @ 2015-03-04 23:31 ` Stefan Brüns [not found] ` <1425511870-3303-1-git-send-email-stefan.bruens@rwth-aachen.de> 1 sibling, 0 replies; 10+ messages in thread From: Stefan Brüns @ 2015-03-04 23:31 UTC (permalink / raw) To: linux-input; +Cc: Stefan Brüns The description was requested 5 years ago: https://lkml.org/lkml/2010/2/27/36 See also http://comments.gmane.org/gmane.linux.kernel.input/11175 Stefan Brüns (2): Add alias KEY_ROTATE_DISPLAY for KEY_DIRECTION, add description use more descriptive KEY_ROTATE_DISPLAY instead of KEY_DIRECTION drivers/hid/hid-debug.c | 2 +- drivers/platform/x86/fujitsu-tablet.c | 6 +++--- drivers/platform/x86/hp-wmi.c | 2 +- include/uapi/linux/input.h | 3 ++- 4 files changed, 7 insertions(+), 6 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <1425511870-3303-1-git-send-email-stefan.bruens@rwth-aachen.de>]
* [PATCH v2 1/2] Add alias KEY_ROTATE_DISPLAY for KEY_DIRECTION, add description [not found] ` <1425511870-3303-1-git-send-email-stefan.bruens@rwth-aachen.de> @ 2015-03-04 23:31 ` Stefan Brüns 2015-03-06 7:54 ` Dmitry Torokhov 2015-03-04 23:31 ` [PATCH 2/2] use more descriptive KEY_ROTATE_DISPLAY instead of KEY_DIRECTION Stefan Brüns 1 sibling, 1 reply; 10+ messages in thread From: Stefan Brüns @ 2015-03-04 23:31 UTC (permalink / raw) To: linux-input; +Cc: Stefan Brüns Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> --- include/uapi/linux/input.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index a1d7e93..47b0138 100644 --- a/include/uapi/linux/input.h +++ b/include/uapi/linux/input.h @@ -368,7 +368,8 @@ struct input_keymap_entry { #define KEY_MSDOS 151 #define KEY_COFFEE 152 /* AL Terminal Lock/Screensaver */ #define KEY_SCREENLOCK KEY_COFFEE -#define KEY_DIRECTION 153 +#define KEY_DIRECTION 153 /* Display orientation for e.g. tablets */ +#define KEY_ROTATE_DISPLAY KEY_DIRECTION #define KEY_CYCLEWINDOWS 154 #define KEY_MAIL 155 #define KEY_BOOKMARKS 156 /* AC Bookmarks */ -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/2] Add alias KEY_ROTATE_DISPLAY for KEY_DIRECTION, add description 2015-03-04 23:31 ` [PATCH v2 1/2] Add alias KEY_ROTATE_DISPLAY for KEY_DIRECTION, add description Stefan Brüns @ 2015-03-06 7:54 ` Dmitry Torokhov 0 siblings, 0 replies; 10+ messages in thread From: Dmitry Torokhov @ 2015-03-06 7:54 UTC (permalink / raw) To: Stefan Brüns; +Cc: linux-input On Thu, Mar 05, 2015 at 12:31:09AM +0100, Stefan Brüns wrote: > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> Applied, but made KEY_ROTATE_DISPLAY primary. > --- > include/uapi/linux/input.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h > index a1d7e93..47b0138 100644 > --- a/include/uapi/linux/input.h > +++ b/include/uapi/linux/input.h > @@ -368,7 +368,8 @@ struct input_keymap_entry { > #define KEY_MSDOS 151 > #define KEY_COFFEE 152 /* AL Terminal Lock/Screensaver */ > #define KEY_SCREENLOCK KEY_COFFEE > -#define KEY_DIRECTION 153 > +#define KEY_DIRECTION 153 /* Display orientation for e.g. tablets */ > +#define KEY_ROTATE_DISPLAY KEY_DIRECTION > #define KEY_CYCLEWINDOWS 154 > #define KEY_MAIL 155 > #define KEY_BOOKMARKS 156 /* AC Bookmarks */ > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] use more descriptive KEY_ROTATE_DISPLAY instead of KEY_DIRECTION [not found] ` <1425511870-3303-1-git-send-email-stefan.bruens@rwth-aachen.de> 2015-03-04 23:31 ` [PATCH v2 1/2] Add alias KEY_ROTATE_DISPLAY for KEY_DIRECTION, add description Stefan Brüns @ 2015-03-04 23:31 ` Stefan Brüns 2015-03-06 7:56 ` Dmitry Torokhov 1 sibling, 1 reply; 10+ messages in thread From: Stefan Brüns @ 2015-03-04 23:31 UTC (permalink / raw) To: linux-input; +Cc: Stefan Brüns Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> --- drivers/hid/hid-debug.c | 2 +- drivers/platform/x86/fujitsu-tablet.c | 6 +++--- drivers/platform/x86/hp-wmi.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c index 8bf61d2..1086800 100644 --- a/drivers/hid/hid-debug.c +++ b/drivers/hid/hid-debug.c @@ -814,7 +814,7 @@ static const char *keys[KEY_MAX + 1] = { [KEY_DELETEFILE] = "DeleteFile", [KEY_XFER] = "X-fer", [KEY_PROG1] = "Prog1", [KEY_PROG2] = "Prog2", [KEY_WWW] = "WWW", [KEY_MSDOS] = "MSDOS", - [KEY_COFFEE] = "Coffee", [KEY_DIRECTION] = "Direction", + [KEY_COFFEE] = "Coffee", [KEY_ROTATE_DISPLAY] = "RotateDisplay", [KEY_CYCLEWINDOWS] = "CycleWindows", [KEY_MAIL] = "Mail", [KEY_BOOKMARKS] = "Bookmarks", [KEY_COMPUTER] = "Computer", [KEY_BACK] = "Back", [KEY_FORWARD] = "Forward", diff --git a/drivers/platform/x86/fujitsu-tablet.c b/drivers/platform/x86/fujitsu-tablet.c index 53bdbb0..baea077 100644 --- a/drivers/platform/x86/fujitsu-tablet.c +++ b/drivers/platform/x86/fujitsu-tablet.c @@ -59,7 +59,7 @@ static unsigned short keymap_Lifebook_Tseries[KEYMAP_LEN] __initdata = { KEY_RESERVED, KEY_SCROLLDOWN, KEY_SCROLLUP, - KEY_DIRECTION, + KEY_ROTATE_DISPLAY, KEY_LEFTCTRL, KEY_BRIGHTNESSUP, KEY_BRIGHTNESSDOWN, @@ -116,7 +116,7 @@ static unsigned short keymap_Lifebook_U810[KEYMAP_LEN] __initdata = { KEY_RESERVED, KEY_PROG1, KEY_PROG2, - KEY_DIRECTION, + KEY_ROTATE_DISPLAY, KEY_RESERVED, KEY_RESERVED, KEY_RESERVED, @@ -153,7 +153,7 @@ static unsigned short keymap_Stylistic_ST5xxx[KEYMAP_LEN] __initdata = { KEY_RESERVED, KEY_RESERVED, KEY_MAIL, - KEY_DIRECTION, + KEY_ROTATE_DISPLAY, KEY_ESC, KEY_ENTER, KEY_BRIGHTNESSUP, diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c index 0ab2b37..0669731 100644 --- a/drivers/platform/x86/hp-wmi.c +++ b/drivers/platform/x86/hp-wmi.c @@ -144,7 +144,7 @@ static const struct key_entry hp_wmi_keymap[] = { { KE_KEY, 0x20e8, { KEY_MEDIA } }, { KE_KEY, 0x2142, { KEY_MEDIA } }, { KE_KEY, 0x213b, { KEY_INFO } }, - { KE_KEY, 0x2169, { KEY_DIRECTION } }, + { KE_KEY, 0x2169, { KEY_ROTATE_DISPLAY } }, { KE_KEY, 0x216a, { KEY_SETUP } }, { KE_KEY, 0x231b, { KEY_HELP } }, { KE_END, 0 } -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] use more descriptive KEY_ROTATE_DISPLAY instead of KEY_DIRECTION 2015-03-04 23:31 ` [PATCH 2/2] use more descriptive KEY_ROTATE_DISPLAY instead of KEY_DIRECTION Stefan Brüns @ 2015-03-06 7:56 ` Dmitry Torokhov 2015-03-06 18:15 ` Darren Hart 0 siblings, 1 reply; 10+ messages in thread From: Dmitry Torokhov @ 2015-03-06 7:56 UTC (permalink / raw) To: Stefan Brüns; +Cc: linux-input, Darren Hart, Jiri Kosina On Thu, Mar 05, 2015 at 12:31:10AM +0100, Stefan Brüns wrote: > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> This should go through HID and platform trees unless I hear otherwise. > --- > drivers/hid/hid-debug.c | 2 +- > drivers/platform/x86/fujitsu-tablet.c | 6 +++--- > drivers/platform/x86/hp-wmi.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c > index 8bf61d2..1086800 100644 > --- a/drivers/hid/hid-debug.c > +++ b/drivers/hid/hid-debug.c > @@ -814,7 +814,7 @@ static const char *keys[KEY_MAX + 1] = { > [KEY_DELETEFILE] = "DeleteFile", [KEY_XFER] = "X-fer", > [KEY_PROG1] = "Prog1", [KEY_PROG2] = "Prog2", > [KEY_WWW] = "WWW", [KEY_MSDOS] = "MSDOS", > - [KEY_COFFEE] = "Coffee", [KEY_DIRECTION] = "Direction", > + [KEY_COFFEE] = "Coffee", [KEY_ROTATE_DISPLAY] = "RotateDisplay", > [KEY_CYCLEWINDOWS] = "CycleWindows", [KEY_MAIL] = "Mail", > [KEY_BOOKMARKS] = "Bookmarks", [KEY_COMPUTER] = "Computer", > [KEY_BACK] = "Back", [KEY_FORWARD] = "Forward", > diff --git a/drivers/platform/x86/fujitsu-tablet.c b/drivers/platform/x86/fujitsu-tablet.c > index 53bdbb0..baea077 100644 > --- a/drivers/platform/x86/fujitsu-tablet.c > +++ b/drivers/platform/x86/fujitsu-tablet.c > @@ -59,7 +59,7 @@ static unsigned short keymap_Lifebook_Tseries[KEYMAP_LEN] __initdata = { > KEY_RESERVED, > KEY_SCROLLDOWN, > KEY_SCROLLUP, > - KEY_DIRECTION, > + KEY_ROTATE_DISPLAY, > KEY_LEFTCTRL, > KEY_BRIGHTNESSUP, > KEY_BRIGHTNESSDOWN, > @@ -116,7 +116,7 @@ static unsigned short keymap_Lifebook_U810[KEYMAP_LEN] __initdata = { > KEY_RESERVED, > KEY_PROG1, > KEY_PROG2, > - KEY_DIRECTION, > + KEY_ROTATE_DISPLAY, > KEY_RESERVED, > KEY_RESERVED, > KEY_RESERVED, > @@ -153,7 +153,7 @@ static unsigned short keymap_Stylistic_ST5xxx[KEYMAP_LEN] __initdata = { > KEY_RESERVED, > KEY_RESERVED, > KEY_MAIL, > - KEY_DIRECTION, > + KEY_ROTATE_DISPLAY, > KEY_ESC, > KEY_ENTER, > KEY_BRIGHTNESSUP, > diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c > index 0ab2b37..0669731 100644 > --- a/drivers/platform/x86/hp-wmi.c > +++ b/drivers/platform/x86/hp-wmi.c > @@ -144,7 +144,7 @@ static const struct key_entry hp_wmi_keymap[] = { > { KE_KEY, 0x20e8, { KEY_MEDIA } }, > { KE_KEY, 0x2142, { KEY_MEDIA } }, > { KE_KEY, 0x213b, { KEY_INFO } }, > - { KE_KEY, 0x2169, { KEY_DIRECTION } }, > + { KE_KEY, 0x2169, { KEY_ROTATE_DISPLAY } }, > { KE_KEY, 0x216a, { KEY_SETUP } }, > { KE_KEY, 0x231b, { KEY_HELP } }, > { KE_END, 0 } > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] use more descriptive KEY_ROTATE_DISPLAY instead of KEY_DIRECTION 2015-03-06 7:56 ` Dmitry Torokhov @ 2015-03-06 18:15 ` Darren Hart 2015-03-06 21:45 ` Jiri Kosina 0 siblings, 1 reply; 10+ messages in thread From: Darren Hart @ 2015-03-06 18:15 UTC (permalink / raw) To: Dmitry Torokhov; +Cc: Stefan Brüns, linux-input, Jiri Kosina On Thu, Mar 05, 2015 at 11:56:00PM -0800, Dmitry Torokhov wrote: > On Thu, Mar 05, 2015 at 12:31:10AM +0100, Stefan Brüns wrote: > > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> > > This should go through HID and platform trees unless I hear otherwise. I'll defer to Jiri on this. Jiri, please feel free to pull the drivers/platform/x86 changes through your tree. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] use more descriptive KEY_ROTATE_DISPLAY instead of KEY_DIRECTION 2015-03-06 18:15 ` Darren Hart @ 2015-03-06 21:45 ` Jiri Kosina 2015-03-07 0:34 ` Dmitry Torokhov 0 siblings, 1 reply; 10+ messages in thread From: Jiri Kosina @ 2015-03-06 21:45 UTC (permalink / raw) To: Darren Hart; +Cc: Dmitry Torokhov, Stefan Brüns, linux-input On Fri, 6 Mar 2015, Darren Hart wrote: > > > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> > > > > This should go through HID and platform trees unless I hear otherwise. > > I'll defer to Jiri on this. Jiri, please feel free to pull the > drivers/platform/x86 changes through your tree. Dmitry, as you already merged the patch which aliases KEY_ROTATE_DISPLAY to KEY_DIRECTION, please also take this one so that we avoid unnecessary cross-tree dependencies. Feel free to add Acked-by: Jiri Kosina <jkosina@suse.cz> to this one. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] use more descriptive KEY_ROTATE_DISPLAY instead of KEY_DIRECTION 2015-03-06 21:45 ` Jiri Kosina @ 2015-03-07 0:34 ` Dmitry Torokhov 0 siblings, 0 replies; 10+ messages in thread From: Dmitry Torokhov @ 2015-03-07 0:34 UTC (permalink / raw) To: Jiri Kosina; +Cc: Darren Hart, Stefan Brüns, linux-input On Fri, Mar 06, 2015 at 10:45:52PM +0100, Jiri Kosina wrote: > On Fri, 6 Mar 2015, Darren Hart wrote: > > > > > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> > > > > > > This should go through HID and platform trees unless I hear otherwise. > > > > I'll defer to Jiri on this. Jiri, please feel free to pull the > > drivers/platform/x86 changes through your tree. > > Dmitry, as you already merged the patch which aliases KEY_ROTATE_DISPLAY > to KEY_DIRECTION, please also take this one so that we avoid unnecessary > cross-tree dependencies. Feel free to add > > Acked-by: Jiri Kosina <jkosina@suse.cz> Applied, thank you. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-03-07 0:34 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-04 21:42 [PATCH] Add short KEY_DIRECTION description Stefan Brüns
2015-03-04 21:56 ` Bastien Nocera
2015-03-04 23:31 ` [PATCH 0/2] Replace KEY_DIRECTION with KEY_ROTATE_DISPLAY Stefan Brüns
[not found] ` <1425511870-3303-1-git-send-email-stefan.bruens@rwth-aachen.de>
2015-03-04 23:31 ` [PATCH v2 1/2] Add alias KEY_ROTATE_DISPLAY for KEY_DIRECTION, add description Stefan Brüns
2015-03-06 7:54 ` Dmitry Torokhov
2015-03-04 23:31 ` [PATCH 2/2] use more descriptive KEY_ROTATE_DISPLAY instead of KEY_DIRECTION Stefan Brüns
2015-03-06 7:56 ` Dmitry Torokhov
2015-03-06 18:15 ` Darren Hart
2015-03-06 21:45 ` Jiri Kosina
2015-03-07 0:34 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).