From: Darren Hart <dvhart@infradead.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Bastien Nocera <hadess@hadess.net>, Jiri Kosina <jkosina@suse.cz>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net,
linux-input@vger.kernel.org
Subject: Re: [ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence
Date: Fri, 6 Mar 2015 10:09:34 -0800 [thread overview]
Message-ID: <20150306180934.GE19001@vmdeb7> (raw)
In-Reply-To: <1425407994.1004750.235001957.08166EE5@webmail.messagingengine.com>
On Tue, Mar 03, 2015 at 03:39:54PM -0300, Henrique de Moraes Holschuh wrote:
> On Tue, Mar 3, 2015, at 13:52, Darren Hart wrote:
> > Henrique, I believe I may have overstepped with thinkpad-acpi and dealt
> > with it like the other drivers in platform/drivers/x86, when instead I should
> > have been leaving it to you. My apologies, it was not intentional.
>
> No harm done! And I did appreciate the extra help :-)
>
> > Do you typically send pull-requests for the thinkpad-acpi driver directly to Linus?
>
> thinkpad-acpi is part of the platform-x86 subsystem, so IMHO it should
> continue to be merged through your tree if you are okay with that.
>
> I'd really appreciate if the typical patch approval flux would go
> through me first. However, I certainly don't mind if you merge patches
> directly should I be unresponsible for some reason, or when they are
> part of the usual tree-wide spot fixes for some pattern/anti-pattern,
> etc.
>
> > I would be more than happy to basically ignore anything to thinkpad-acpi until
> > after you have provided a review. I can also roll up pull requests from
> > you if you prefer to integrate into the platform-drivers-x86 tree as the path to
> > Linus.
>
> Well, if it is fine with you, I'd suggest we continue with the process
> used in this patchset, where I will reply to patches in this ML with a
> reviewed-by or acked-by before you merge them.
>
> If you want to change that at some point, just drop me a note and I will
> start pushing patches to you either through this ML or through signed
> pull requests, whichever you prefer.
Great. Things are documented correctly in MAINTAINERS then and we can continue
as before, only I will be more diligent making sure you are Cc'd and have
responded to any thinkpad-acpi.c changes. I assume two weeks is sufficient, but
may nag you after a week.
Thanks!
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2015-03-06 18:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 14:44 [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence Bastien Nocera
2015-02-26 6:18 ` Darren Hart
2015-02-26 11:22 ` Bastien Nocera
2015-02-27 11:15 ` Henrique de Moraes Holschuh
2015-02-27 11:05 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2015-02-27 11:16 ` Henrique de Moraes Holschuh
2015-03-03 16:52 ` Darren Hart
2015-03-03 18:39 ` Henrique de Moraes Holschuh
2015-03-06 18:09 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306180934.GE19001@vmdeb7 \
--to=dvhart@infradead.org \
--cc=hadess@hadess.net \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).