linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mathias Gottschlag <mgottschlag@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 3/4] psmouse: Disable resolution/rate/scale changes for FocalTech touchpads.
Date: Sat, 7 Mar 2015 20:14:34 -0800	[thread overview]
Message-ID: <20150308041434.GA1482@dtor-ws> (raw)
In-Reply-To: <1424992808-29891-4-git-send-email-mgottschlag@gmail.com>

Hi Mathias,

On Fri, Feb 27, 2015 at 12:20:07AM +0100, Mathias Gottschlag wrote:
> These PS/2 commands make some touchpads stop responding, so this commit
> adds some dummy functions to replace the generic implementation. Because
> @@ -60,6 +65,7 @@ struct psmouse {
>  
>  	unsigned int rate;
>  	unsigned int resolution;
> +	enum psmouse_scale scale;
>  	unsigned int resetafter;
>  	unsigned int resync_time;
>  	bool smartscroll;	/* Logitech only */

I do not believe we need to store the scaling factor so I dropped these
chunks, otherwise applied all 4.

Thanks.

-- 
Dmitry

  reply	other threads:[~2015-03-08  4:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-14 19:01 [PATCH 0/3] Fix a regression in the FocalTech touchpad driver Mathias Gottschlag
2015-02-14 19:01 ` [PATCH 1/3] psmouse: Remove hardcoded touchpad size from the focaltech driver Mathias Gottschlag
2015-02-18 19:57   ` Dmitry Torokhov
2015-02-14 19:01 ` [PATCH 2/3] psmouse: Skip psmouse_initialize for FocalTech touchpads Mathias Gottschlag
2015-02-18 19:55   ` Dmitry Torokhov
2015-02-14 19:01 ` [PATCH 3/3] psmouse: Disable resolution/rate changes " Mathias Gottschlag
2015-02-26 23:20 ` [PATCHv2 0/4] FocalTech touchpad fixes Mathias Gottschlag
2015-02-26 23:20   ` [PATCHv2 1/4] psmouse: Remove hardcoded touchpad size from the focaltech driver Mathias Gottschlag
2015-02-26 23:20   ` [PATCHv2 2/4] psmouse: Ensure that the focaltech driver reports consistent coordinates Mathias Gottschlag
2015-02-26 23:20   ` [PATCHv2 3/4] psmouse: Disable resolution/rate/scale changes for FocalTech touchpads Mathias Gottschlag
2015-03-08  4:14     ` Dmitry Torokhov [this message]
2015-02-26 23:20   ` [PATCHv2 4/4] psmouse: Disable "palm detection" in the focaltech driver Mathias Gottschlag

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150308041434.GA1482@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgottschlag@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).