From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Olivier Sobrie <olivier@sobrie.be>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: misc: pwm-beeper: remove useless call to pwm_config()
Date: Thu, 12 Mar 2015 14:47:52 -0700 [thread overview]
Message-ID: <20150312214752.GB4720@dtor-ws> (raw)
In-Reply-To: <1426165770-11130-1-git-send-email-olivier@sobrie.be>
On Thu, Mar 12, 2015 at 02:09:30PM +0100, Olivier Sobrie wrote:
> Calling pwm_config() with a period equal to zero always results in
> error (-EINVAL) and pwm chip config method is never called.
>
> Signed-off-by: Olivier Sobrie <olivier@sobrie.be>
Applied, thank you.
> ---
> drivers/input/misc/pwm-beeper.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
> index a28ee70..2a23643 100644
> --- a/drivers/input/misc/pwm-beeper.c
> +++ b/drivers/input/misc/pwm-beeper.c
> @@ -50,7 +50,6 @@ static int pwm_beeper_event(struct input_dev *input,
> }
>
> if (value == 0) {
> - pwm_config(beeper->pwm, 0, 0);
> pwm_disable(beeper->pwm);
> } else {
> period = HZ_TO_NANOSECONDS(value);
> --
> 1.9.1
>
--
Dmitry
prev parent reply other threads:[~2015-03-12 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 13:09 [PATCH] input: misc: pwm-beeper: remove useless call to pwm_config() Olivier Sobrie
2015-03-12 21:47 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312214752.GB4720@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olivier@sobrie.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).