* [PATCH] input: misc: pwm-beeper: remove useless call to pwm_config()
@ 2015-03-12 13:09 Olivier Sobrie
2015-03-12 21:47 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Olivier Sobrie @ 2015-03-12 13:09 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, Olivier Sobrie
Calling pwm_config() with a period equal to zero always results in
error (-EINVAL) and pwm chip config method is never called.
Signed-off-by: Olivier Sobrie <olivier@sobrie.be>
---
drivers/input/misc/pwm-beeper.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
index a28ee70..2a23643 100644
--- a/drivers/input/misc/pwm-beeper.c
+++ b/drivers/input/misc/pwm-beeper.c
@@ -50,7 +50,6 @@ static int pwm_beeper_event(struct input_dev *input,
}
if (value == 0) {
- pwm_config(beeper->pwm, 0, 0);
pwm_disable(beeper->pwm);
} else {
period = HZ_TO_NANOSECONDS(value);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] input: misc: pwm-beeper: remove useless call to pwm_config()
2015-03-12 13:09 [PATCH] input: misc: pwm-beeper: remove useless call to pwm_config() Olivier Sobrie
@ 2015-03-12 21:47 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2015-03-12 21:47 UTC (permalink / raw)
To: Olivier Sobrie; +Cc: linux-input, linux-kernel
On Thu, Mar 12, 2015 at 02:09:30PM +0100, Olivier Sobrie wrote:
> Calling pwm_config() with a period equal to zero always results in
> error (-EINVAL) and pwm chip config method is never called.
>
> Signed-off-by: Olivier Sobrie <olivier@sobrie.be>
Applied, thank you.
> ---
> drivers/input/misc/pwm-beeper.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
> index a28ee70..2a23643 100644
> --- a/drivers/input/misc/pwm-beeper.c
> +++ b/drivers/input/misc/pwm-beeper.c
> @@ -50,7 +50,6 @@ static int pwm_beeper_event(struct input_dev *input,
> }
>
> if (value == 0) {
> - pwm_config(beeper->pwm, 0, 0);
> pwm_disable(beeper->pwm);
> } else {
> period = HZ_TO_NANOSECONDS(value);
> --
> 1.9.1
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-12 21:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-12 13:09 [PATCH] input: misc: pwm-beeper: remove useless call to pwm_config() Olivier Sobrie
2015-03-12 21:47 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).