From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v3 1/5] i8042: intel-8042 DT documentation Date: Sat, 14 Mar 2015 20:20:38 -0700 Message-ID: <20150315032038.GA13064@dtor-ws> References: <1423857173-16432-6-git-send-email-v1ron@v1ros.org> <1424034707-15723-1-git-send-email-v1ron@v1ros.org> <1424034707-15723-2-git-send-email-v1ron@v1ros.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1424034707-15723-2-git-send-email-v1ron-oLhuKTjYqW/YtjvyW6yDsg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roman Volkov Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , Hans de Goede , Jiri Kosina , Wolfram Sang , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tony Prisk List-Id: linux-input@vger.kernel.org Hi Roman, On Mon, Feb 16, 2015 at 12:11:43AM +0300, Roman Volkov wrote: > Documentation for 'intel,8042' DT compatible node. > > Signed-off-by: Tony Prisk > Signed-off-by: Roman Volkov > --- > .../devicetree/bindings/input/intel-8042.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/intel-8042.txt > > diff --git a/Documentation/devicetree/bindings/input/intel-8042.txt b/Documentation/devicetree/bindings/input/intel-8042.txt > new file mode 100644 > index 0000000..ab8a3e0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/intel-8042.txt > @@ -0,0 +1,26 @@ > +Intel 8042 Keyboard Controller > + > +Required properties: > +- compatible: should be "intel,8042" > +- regs: memory for keyboard controller > +- interrupts: usually, two interrupts should be specified (keyboard and aux). > + However, only one interrupt is also allowed in case of absence of the > + physical port in the controller. The i8042 driver must be loaded with > + nokbd/noaux option in this case. > +- interrupt-names: interrupt names corresponding to numbers in the list. > + "kbd" is the keyboard interrupt and "aux" is the auxiliary (mouse) > + interrupt. > +- command-reg: offset in memory for command register > +- status-reg: offset in memory for status register > +- data-reg: offset in memory for data register > + > +Example: > + i8042@d8008800 { > + compatible = "intel,8042"; > + regs = <0xd8008800 0x100>; > + interrupts = <23>, <4>; > + interrupt-names = "kbd", "aux"; > + command-reg = <0x04>; > + status-reg = <0x04>; > + data-reg = <0x00>; > + }; No, we already have existing OF bindings for i8042 on sparc and powerpc, I do not think we need to invent a brand new one. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html