From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 24/35 linux-next] Input: constify of_device_id array
Date: Wed, 18 Mar 2015 09:59:40 -0700 [thread overview]
Message-ID: <20150318165940.GC11485@dtor-ws> (raw)
In-Reply-To: <1426535685-25996-3-git-send-email-fabf@skynet.be>
On Mon, Mar 16, 2015 at 08:54:34PM +0100, Fabian Frederick wrote:
> of_device_id is always used as const.
> (See driver.of_match_table and open firmware functions)
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Applied, thank you.
> ---
> drivers/input/misc/palmas-pwrbutton.c | 2 +-
> drivers/input/misc/regulator-haptic.c | 2 +-
> drivers/input/misc/tps65218-pwrbutton.c | 2 +-
> drivers/input/touchscreen/ar1021_i2c.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/misc/palmas-pwrbutton.c b/drivers/input/misc/palmas-pwrbutton.c
> index 1f9b5ee..1e1baed 100644
> --- a/drivers/input/misc/palmas-pwrbutton.c
> +++ b/drivers/input/misc/palmas-pwrbutton.c
> @@ -304,7 +304,7 @@ static SIMPLE_DEV_PM_OPS(palmas_pwron_pm,
> palmas_pwron_suspend, palmas_pwron_resume);
>
> #ifdef CONFIG_OF
> -static struct of_device_id of_palmas_pwr_match[] = {
> +static const struct of_device_id of_palmas_pwr_match[] = {
> { .compatible = "ti,palmas-pwrbutton" },
> { },
> };
> diff --git a/drivers/input/misc/regulator-haptic.c b/drivers/input/misc/regulator-haptic.c
> index 132eb91..6bf3f10 100644
> --- a/drivers/input/misc/regulator-haptic.c
> +++ b/drivers/input/misc/regulator-haptic.c
> @@ -245,7 +245,7 @@ static int __maybe_unused regulator_haptic_resume(struct device *dev)
> static SIMPLE_DEV_PM_OPS(regulator_haptic_pm_ops,
> regulator_haptic_suspend, regulator_haptic_resume);
>
> -static struct of_device_id regulator_haptic_dt_match[] = {
> +static const struct of_device_id regulator_haptic_dt_match[] = {
> { .compatible = "regulator-haptic" },
> { /* sentinel */ },
> };
> diff --git a/drivers/input/misc/tps65218-pwrbutton.c b/drivers/input/misc/tps65218-pwrbutton.c
> index 54508dec..a39b626 100644
> --- a/drivers/input/misc/tps65218-pwrbutton.c
> +++ b/drivers/input/misc/tps65218-pwrbutton.c
> @@ -106,7 +106,7 @@ static int tps65218_pwron_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static struct of_device_id of_tps65218_pwr_match[] = {
> +static const struct of_device_id of_tps65218_pwr_match[] = {
> { .compatible = "ti,tps65218-pwrbutton" },
> { },
> };
> diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
> index ba30578..f0b954d 100644
> --- a/drivers/input/touchscreen/ar1021_i2c.c
> +++ b/drivers/input/touchscreen/ar1021_i2c.c
> @@ -157,7 +157,7 @@ static const struct i2c_device_id ar1021_i2c_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, ar1021_i2c_id);
>
> -static struct of_device_id ar1021_i2c_of_match[] = {
> +static const struct of_device_id ar1021_i2c_of_match[] = {
> { .compatible = "microchip,ar1021-i2c", },
> { }
> };
> --
> 2.1.0
>
--
Dmitry
prev parent reply other threads:[~2015-03-18 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 19:17 [PATCH 00/35 linux-next] constify of_device_id array Fabian Frederick
[not found] ` <1426535685-25996-1-git-send-email-fabf@skynet.be>
2015-03-16 19:54 ` [PATCH 24/35 linux-next] Input: " Fabian Frederick
2015-03-18 16:59 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318165940.GC11485@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=fabf@skynet.be \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).