From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v3] input: Add support for ChipOne icn8318 based touchscreens Date: Sat, 21 Mar 2015 21:03:05 -0700 Message-ID: <20150322040305.GA40622@dtor-ws> References: <1426007133-9606-1-git-send-email-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1426007133-9606-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hans de Goede Cc: linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: linux-input@vger.kernel.org Hi Hans, On Tue, Mar 10, 2015 at 06:05:33PM +0100, Hans de Goede wrote: > + error = devm_request_threaded_irq(dev, client->irq, NULL, icn8318_irq, > + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, Shouldn't we let DT data tell us what trigger to use? I.e. just leave IRQF_ONESHOT here? No need to resubmit, just let me know if you agree/disagree... Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html