From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: Ramiro Morales <cramm0@gmail.com>,
linux-input <linux-input@vger.kernel.org>
Subject: Re: [PATCH] Input: synaptics - quirk for Thinkpad E440
Date: Mon, 23 Mar 2015 10:34:43 -0700 [thread overview]
Message-ID: <20150323173443.GA11116@dtor-ws> (raw)
In-Reply-To: <CAN+gG=G1byht7trjgGpUzEtHWUnK3stmxV0hjNTx0WzSgnOk8g@mail.gmail.com>
On Mon, Mar 23, 2015 at 12:58:16PM -0400, Benjamin Tissoires wrote:
> On Sat, Mar 21, 2015 at 9:24 AM, Ramiro Morales <cramm0@gmail.com> wrote:
> > On Thu, Mar 19, 2015 at 7:15 PM, Benjamin Tissoires
> > <benjamin.tissoires@gmail.com> wrote:
> >> Then I am even more surprised that you need to quirk a late 2014
> >> haswell refresh.
> >>
> >> Can you post your dmesg when booting the synaptics branch so that we
> >> can check if the FW has the correct values stored or if we really need
> >> to quirk it?
> >
> > On Thu, Mar 19, 2015 at 7:15 PM, Benjamin Tissoires
> > <benjamin.tissoires@gmail.com> wrote:
> >> Then I am even more surprised that you need to quirk a late 2014
> >> haswell refresh.
> >
> > Actually the laptop manufacturing date is Nov '13, I bought it on May.
> >
> > This patch is almost a year late because I had a false start
> > submitting fixes through the Ubuntu BTS[1] only to discover that a
> > clashing quirk for the E540 got added upstream about the same time.
> > The ability to include the board ID in the quirk table logic added by
> > this branch provides a way out.
> >
> >> Can you post your dmesg when booting the synaptics branch so that we
> >> can check if the FW has the correct values stored or if we really need
> >> to quirk it?
> >
> > Here it is:
> >
> > https://dl.dropboxusercontent.com/u/5403630/dmesg_thinkpad_e440_synaptics_8f004f3f.txt
>
> Thanks for all these information. So indeed, your patch is entirely
> valid and is:
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Applied, thank you.
>
> Cheers,
> Benjamin
>
> >
> > Regards,
> >
> >
> > [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1395243
> > [2] https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?id=bce4f9e764c36bc35dd5c9cf9e057c09f422397d
> >
> > --
> > Ramiro Morales
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-input" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Dmitry
prev parent reply other threads:[~2015-03-23 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 10:37 [PATCH] Input: synaptics - quirk for Thinkpad E440 Ramiro Morales
2015-03-19 15:17 ` Ramiro Morales
2015-03-19 22:15 ` Benjamin Tissoires
2015-03-21 13:24 ` Ramiro Morales
2015-03-23 16:58 ` Benjamin Tissoires
2015-03-23 17:34 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323173443.GA11116@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@gmail.com \
--cc=cramm0@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).