linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] HID: input: Fix NULL pointer dereference when power_supply_register fails
Date: Tue, 24 Mar 2015 16:07:06 +0100	[thread overview]
Message-ID: <20150324150706.GA22934@earth> (raw)
In-Reply-To: <alpine.LNX.2.00.1503241200220.6781@pobox.suse.cz>

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

Hi Krzysztof & Jiri,

On Tue, Mar 24, 2015 at 12:02:41PM +0100, Jiri Kosina wrote:
> On Mon, 23 Mar 2015, Krzysztof Kozlowski wrote:
> 
> > Do not call power_supply_powers() if power_supply_register() failed
> > earlier. This fixes possible NULL pointer dereference by
> > power_supply_powers() in such case.
> > 
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > 
> > ---
> > 
> > The patch was prepared on top of next-20150323. It depends on changes in
> > power supply core (battery-2.6.git) so probably it should be applied to
> > the battery tree.
> 
> Acked-by: Jiri Kosina <jkosina@suse.cz>
> 
> for the merge through battery-2.6.git. Thanks.

Thanks, pulled.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2015-03-24 15:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 15:34 [PATCH] HID: input: Fix NULL pointer dereference when power_supply_register fails Krzysztof Kozlowski
2015-03-24 11:02 ` Jiri Kosina
2015-03-24 15:07   ` Sebastian Reichel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150324150706.GA22934@earth \
    --to=sre@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=jkosina@suse.cz \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).