Re: [PATCH FIX for 4.0 0/2] alps: Report alps v2 Dualpoint Stick events via the right event node

["Pali Rohár" <pali.rohar@gmail.com>]

[-- Attachment #1: Type: Text/Plain, Size: 1513 bytes --]

On Wednesday 01 April 2015 17:44:04 Hans de Goede wrote:
> Hi Dmitry & Pali,
> 
> While working on some libinput code to deal with trackpoints
> of different model laptops having quite different speed /
> sensitivity ootb, I noticed that with the current 4.0-rc#
> kernels the trackpoint events on laptops with a PROTO_V2 alps
> touchpad are no longer being send by the "Dualpoint Stick"
> event node, instead a new "ALPS PS/2 Mouse" node gets created
> and sends the trackpoint events.
> 
> The cause of this is that the stick on these devices sends
> bare ps/2 packets as data.
> 
> Although this does not really break anything (atm, it does
> break my libinput work), it is still wrong, esp. also since
> the "Dualpoint Stick" node has the POINTING_STICK property
> set, where as the "ALPS PS/2 Mouse" node which is actually
> sending the stick events does not.
> 
> If still possible I would like to see this fixes added to 4.0,
> if not we should queue them up for stable.
> 
> Regards,
> 
> Hans

Hi Hans, thanks for testing!

I would like to see this observation also in alps protocol 
documentation, where is all information how are data from 
touchpads and tracksticks reported.

Also for me it it makes sense to squash both patches into one.

And can you check if your change is needed only for 
ALPS_PS2_INTERLEAVED devices? For me it looks like that only 
those alps devices could mix both 3-bytes and 6-bytes packets...

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]