Re: [PATCH] Input: goodix - preliminary support for GT801-2+1

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Sun, Apr 05, 2015 at 08:06:16PM +0300, Priit Laes wrote:
> On Sun, 2015-04-05 at 18:04 +0200, Bastien Nocera wrote:
> > On Sun, 2015-04-05 at 00:08 +0300, Priit Laes wrote:
> > > This patch implements GT801x2 touchscreen support.
> > > Unfortunately, there is a big difference between GT801 and GT9xx 
> > > series
> > > chips, therefore some advice is needed on how to proceed.
> > > 
> > > Differences between GT801x2 and GT9xx series:
> > > 
> > > 1. I2C registers: 1 byte (GT801x2) vs 2 bytes (GT9xx)
> > > 2. Different configuration layout and version info
> > > 3. Different touch report protocol
> > 
> > That doesn't seem like an awful lot of differences. Approximately 80 
> > line changes for 500 lines of driver code. You could add an enum for 
> > the 8xx and 9xx types near the top, add that as driver data in the 
> > match arrays (both the ACPI and OF ones). Then have if statements 
> > choose the correct init, read and report functions.
> 
> How should I handle the version readout?
> 
> Currently the driver has following info in its registers (starting 
> from 0xf0):
> 
> f0: 47 54 38 30 31 4e 49 5f 33 52 31 35 5f 31 41 56    GT801NI_3R15_1AV
> 
> 
> And there's another issue with deactivating interrupts. When I remove 
> the goodix module, I get following traceback:
> 
> [snip]
> WARNING: CPU: 0 PID: 381 at fs/proc/generic.c:552 remove_proc_entry+0x138/0x16c()
> remove_proc_entry: removing non-empty directory 'irq/50', leaking at least 'gt801x2'
> Modules linked in: goodix(-) rtl8192cu rtl_usb rtl8192c_common rtlwifi

This is an issue with the i2c core and not the driver; the offending
patch has been reverted as far as I can remember.

Thanks.

-- 
Dmitry