From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: atkbd: Fix release quirk for Dell models Date: Thu, 9 Apr 2015 09:57:19 -0700 Message-ID: <20150409165719.GC35815@dtor-ws> References: <1427639779-27377-1-git-send-email-pali.rohar@gmail.com> <201504061006.10853@pali> <20150406162056.GA36770@dtor-ws> <201504082254.20875@pali> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ig0-f170.google.com ([209.85.213.170]:36934 "EHLO mail-ig0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751645AbbDIQ5Y (ORCPT ); Thu, 9 Apr 2015 12:57:24 -0400 Content-Disposition: inline In-Reply-To: <201504082254.20875@pali> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Andrew Morton , Matthew Garrett , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Apr 08, 2015 at 10:54:20PM +0200, Pali Roh=E1r wrote: > On Monday 06 April 2015 18:20:56 Dmitry Torokhov wrote: > > On Mon, Apr 06, 2015 at 10:06:10AM +0200, Pali Roh=E1r wrote: > > > On Monday 06 April 2015 01:53:43 Dmitry Torokhov wrote: > > > > On Mon, Apr 06, 2015 at 12:00:32AM +0200, Pali Roh=E1r wrote: > > > > > On Sunday 05 April 2015 23:48:33 Dmitry Torokhov wrote: > > > > > > Hi Pali, > > > > > >=20 > > > > > > On Sun, Mar 29, 2015 at 04:36:19PM +0200, Pali Roh=E1r > > > > > > wrote: > > > > > > > This patch fixes commit 61579ba83934 ("Input: atkbd > > > > > > > - expand Latitude's force release quirk to other > > > > > > > Dells"). Before that commit release quirks were > > > > > > > called for all Dell Latitude models. After that > > > > > > > commit only for Portable Dell devices. But lot of > > > > > > > Latitude models are Laptop or Notebook DMI devices > > > > > > > so quirks are not called. > > > > > > >=20 > > > > > > > Release quirks are still needed also for new Dell > > > > > > > Latitude models, so this patch enables quirks for > > > > > > > all Portable, Laptop, Notebook and Sub-Notebook > > > > > > > Dell devices. > > > > > >=20 > > > > > > Does Dell use all these types for their laptops? What > > > > > > models do you know that need this quirk? > > > > > >=20 > > > > > > Thanks. > > > > >=20 > > > > > I do not if Dell use all types, but months ago Matthew > > > > > wrote to include also other numbers not only 9 (Laptop) > > > > > and you agreed. > > > >=20 > > > > Hmm, I tried looking back but I could not quite find the > > > > discussion. > > >=20 > > > Search for Message-ID: <20141222175632.GB18556@dtor-ws> > > > (this should be unique identifier for emails) > >=20 > > Ah, indeed. Sorry, at this time I completely forgot that we > > are controlling this from userspace nowadays. > >=20 > > > > > I do not know exact list of models which needs these > > > > > quirks, but before that commit (61579ba83934) it was > > > > > used for all Latitude models. At least I see that > > > > > switches do not generate release events and on older > > > > > Latitude machines some Fn keys do not generate them > > > > > too. > > > >=20 > > > > So the question is still: what models do need this quirk > > > > and what chassis type they are used. > > >=20 > > > My model: > > >=20 > > > $ cat /sys/class/dmi/id/chassis_type > > > 9 > > > $ cat /sys/class/dmi/id/sys_vendor > > > Dell Inc. > > > $ cat /sys/class/dmi/id/product_name > > > Latitude E6440 > > >=20 > > > > Regardless, I have not accepted quirks for force_release > > > > and atkbd keymaps for many years now as the task to > > > > adjust both keymap and force_release list has been > > > > offloaded to udev. > > > >=20 > > > > Thanks. > > >=20 > > > Ok, and what to do with kernel regressions? As before commit > > > 61579ba83934 it worked, because quirk was called for all > > > Latitude (independently on chassis_type). > >=20 > > No, this is not a kernel regression because it would mean that > > your laptop worked properly with then current kernel and then > > stopped working. Given that the change went in in 2008 and > > your laptop is a bit newer than that you can't claim kernel > > regression here; as far as I can see the change was > > reasonable for the lineage we had back then, or at least > > noone notified us for about 6 years. > >=20 > > So please do adjust udev rules, there are quite a bit for > > tweaks for Dell and other manufacturer's laptop keyboards > > there). > >=20 > > Thanks. >=20 > Ok, thanks for information. Maybe you can add some comment to=20 > source code or documentation, that this part of code is now=20 > handled by userspace. So other people send patches to correct=20 > place/projects in future. =46air enough. How about below? Thanks. --=20 Dmitry Input: atkbd - document "no new force-release quirks" policy =46rom: Dmitry Torokhov To save people some time let's document that we do not want new quirks = for "force-release" keys in the kernel and that they should patch userspace (udev) instead. Suggested-by: Pali Roh=E1r Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/atkbd.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/at= kbd.c index 387c51f..ec876b5 100644 --- a/drivers/input/keyboard/atkbd.c +++ b/drivers/input/keyboard/atkbd.c @@ -1653,6 +1653,12 @@ static int __init atkbd_deactivate_fixup(const s= truct dmi_system_id *id) return 1; } =20 +/* + * NOTE: do not add any more "force release" quirks to this table. Th= e + * task of adjusting list of keys that should be "released" automatica= lly + * by the driver is now delegated to userspace tools, such as udev, so + * submit such quirks there. + */ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = =3D { { .matches =3D { -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html