From: "Pali Rohár" <pali.rohar@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: atkbd: Fix release quirk for Dell models
Date: Thu, 9 Apr 2015 19:00:50 +0200 [thread overview]
Message-ID: <201504091900.50338@pali> (raw)
In-Reply-To: <20150409165719.GC35815@dtor-ws>
[-- Attachment #1: Type: Text/Plain, Size: 1877 bytes --]
On Thursday 09 April 2015 18:57:19 Dmitry Torokhov wrote:
> On Wed, Apr 08, 2015 at 10:54:20PM +0200, Pali Rohár wrote:
> > On Monday 06 April 2015 18:20:56 Dmitry Torokhov wrote:
> > > On Mon, Apr 06, 2015 at 10:06:10AM +0200, Pali Rohár wrote:
> > >
> > >
> > > Ah, indeed. Sorry, at this time I completely forgot that
> > > we are controlling this from userspace nowadays.
> > >
> > >
> > >
> > >
> > >
> > > No, this is not a kernel regression because it would mean
> > > that your laptop worked properly with then current kernel
> > > and then stopped working. Given that the change went in
> > > in 2008 and your laptop is a bit newer than that you
> > > can't claim kernel regression here; as far as I can see
> > > the change was reasonable for the lineage we had back
> > > then, or at least noone notified us for about 6 years.
> > >
> > >
> > >
> > > So please do adjust udev rules, there are quite a bit for
> > > tweaks for Dell and other manufacturer's laptop keyboards
> > > there).
> > >
> > >
> > >
> > > Thanks.
> >
> >
> >
> > Ok, thanks for information. Maybe you can add some comment
> > to source code or documentation, that this part of code is
> > now handled by userspace. So other people send patches to
> > correct place/projects in future.
>
> Fair enough. How about below?
>
> Thanks.
>
> --
> Dmitry
>
> Input: atkbd - document "no new force-release quirks" policy
>
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> To save people some time let's document that we do not want
> new quirks for "force-release" keys in the kernel and that
> they should patch userspace (udev) instead.
>
> Suggested-by: Pali Rohár <pali.rohar@gmail.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
Looks good for me.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2015-04-09 17:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-29 14:36 [PATCH] Input: atkbd: Fix release quirk for Dell models Pali Rohár
2015-04-04 22:48 ` Pali Rohár
2015-04-05 21:48 ` Dmitry Torokhov
2015-04-05 22:00 ` Pali Rohár
2015-04-05 23:53 ` Dmitry Torokhov
2015-04-06 8:06 ` Pali Rohár
2015-04-06 16:20 ` Dmitry Torokhov
2015-04-08 20:54 ` Pali Rohár
2015-04-09 16:57 ` Dmitry Torokhov
2015-04-09 17:00 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201504091900.50338@pali \
--to=pali.rohar@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).